Move event constants into a new module

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Developer Tools: Netmonitor
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: rickychien, Assigned: jsnajdr)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 52
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [netmonitor])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
This is a code cleaning task before we migrate Net panel to HTML.

- Extracts constants from netmonitor-controller.js and create new event.js module

See: https://github.com/jsnajdr/gecko-dev/blob/98372c04339dfe29b8affa4d5e3766920f190700/devtools/client/netmonitor/events.js
Whiteboard: [devtools-html]
(Assignee)

Updated

a year ago
Assignee: nobody → jsnajdr
Depends on: 1309120
Whiteboard: [netmonitor]
Flags: qe-verify-
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8800193 [details]
Bug 1308495 - Move event constants into a new module

https://reviewboard.mozilla.org/r/85184/#review83744

R+, assuming try is green.

Honza
Attachment #8800193 - Flags: review?(odvarko) → review+
(Assignee)

Comment 3

a year ago
(In reply to Jan Honza Odvarko [:Honza] from comment #2)
> R+, assuming try is green.

Try is running here, together with the sorting patch from bug 1308480:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1753ddc130d

For landing, this depends on landing bug 1309120 (RequestsMenuView separation) first.

Comment 4

a year ago
Pushed by jsnajdr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/797f70b3ef65
Move event constants into a new module r=Honza

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/797f70b3ef65
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Iteration: --- → 52.2 - Oct 17
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.