1308495 - Move event constants into a new module

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

This is a code cleaning task before we migrate Net panel to HTML.

- Extracts constants from netmonitor-controller.js and create new event.js module

See: https://github.com/jsnajdr/gecko-dev/blob/98372c04339dfe29b8affa4d5e3766920f190700/devtools/client/netmonitor/events.js

Comment 1

[Jarda Snajdr [:jsnajdr]]

Attachment: Bug 1308495 - Move event constants into a new module

Review commit: https://reviewboard.mozilla.org/r/85184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85184/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8800193 [details]
Bug 1308495 - Move event constants into a new module

https://reviewboard.mozilla.org/r/85184/#review83744

R+, assuming try is green.

Honza

Comment 3

[Jarda Snajdr [:jsnajdr]]

(In reply to Jan Honza Odvarko [:Honza] from comment #2)
> R+, assuming try is green.

Try is running here, together with the sorting patch from bug 1308480:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1753ddc130d

For landing, this depends on landing bug 1309120 (RequestsMenuView separation) first.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/797f70b3ef65
Move event constants into a new module r=Honza

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/797f70b3ef65