1308584 - [PATCH] add support for riscv64 (RISC-V 64-bit) target

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[david.abdurachmanov]

Attachment: nspr-add-riscv64-target.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36

Steps to reproduce:

Fedora is being bootstrapped on RISC-V 64-bit (aka riscv64) architecture. I have built NSPR 4.12.0 + a patch (attached) and NSPR passed all tests within the testsuite while running in QEMU + Fedora 25 stage3 image.

I am not adding riscv32 or riscv128 as I cannot test these.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 8798981 [details] [diff] [review]
nspr-add-riscv64-target.patch

I have resigned as NSPR module owner. Sorry for the inconvenience.

Comment 2

[Richard Jones]

Although this patch was correct at the time it as submitted, when the changes to GCC were finally submitted by the RISC-V project, the __riscv64 macro was dropped, to be replaced by:

__riscv (defined on all RISC-V platforms)
__riscv_xlen (defined to 32, 64 or 128)

For background on this, see: https://groups.google.com/a/groups.riscv.org/forum/#!topic/sw-dev/EvYRsA2gUjc

Comment 3

[Kai Engert [:KaiE:]]

An updated patch has been attached in the following bug tracker:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892504

It has been suggested that we add it to NSPR.

I don't have to way to test it on that platform, but I assume the people who are contributing the enhancement have sufficiently tested that it works on the new platform.

I suggest that we perform a sanity test, and if it doesn't cause issues with any of the other platforms, I'm fine to add it.

Comment 4

[Kai Engert [:KaiE:]]

Attachment: contributed patch from debian tracker

Comment 5

[Kai Engert [:KaiE:]]

A test build running is running here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e86a12ea21d99eb9bd62469d301ac88bd737b52f

(Because the patch is limited to build rules, the build is limited to building; I excluded test suites.)

Comment 6

[Kai Engert [:KaiE:]]

Comment on attachment 8968145 [details] [diff] [review]
contributed patch from debian tracker

r=kaie because the patch doesn't introduce any regressions for other platforms

Comment 7

[Kai Engert [:KaiE:]]

Checked in:
https://hg.mozilla.org/projects/nspr/rev/f47871e2aeb1