Closed
Bug 1308631
Opened 8 years ago
Closed 8 years ago
Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''char[] java.lang.String.toCharArray()'' on a null object reference at java.io.File.fixSlashes(File.java)
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(fennec51+, firefox51 fixed, firefox52 fixed)
RESOLVED
FIXED
Firefox 52
People
(Reporter: kbrosnan, Assigned: sebastian)
Details
(Keywords: crash, Whiteboard: [MobileAS])
Crash Data
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
Grisha
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
This bug was filed from the Socorro interface and is report bp-debea04f-7219-4322-a7ae-aab9b2161007. ============================================================= java.lang.NullPointerException: Attempt to invoke virtual method 'char[] java.lang.String.toCharArray()' on a null object reference at java.io.File.fixSlashes(File.java:185) at java.io.File.<init>(File.java:134) at org.mozilla.gecko.updater.UpdateService.onHandleIntent(UpdateService.java:211) at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65) at android.os.Handler.dispatchMessage(Handler.java:102) at android.os.Looper.loop(Looper.java:135) at android.os.HandlerThread.run(HandlerThread.java:61)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Reporter | ||
Comment 1•8 years ago
|
||
This is high on Aurora. Conflict with the self updater and the Google Play updates?
Reporter | ||
Updated•8 years ago
|
tracking-fennec: ? → 51+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
Whiteboard: [MobileAS]
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8801654 [details] Bug 1308631 - UpdateService: Do not apply update without update path. https://reviewboard.mozilla.org/r/86328/#review85228
Attachment #8801654 -
Flags: review?(gkruglov) → review+
Pushed by gkruglov@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21ce49aa2942 UpdateService: Do not apply update without update path. r=Grisha
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/21ce49aa2942
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8801654 [details] Bug 1308631 - UpdateService: Do not apply update without update path. Approval Request Comment [Feature/regressing bug #]: Unknown - The oldest crash reports are from 46.0. [User impact if declined]: App can crash in rare situations. We saw multiple reports for Aurora coming in lately (Probably because we distribute it via Google Play now and have a bigger audience). That's why I am requesting uplift. [Describe test coverage new/current, TreeHerder]: Code path can't be tested easily. But patch is simple and straight-forward. [Risks and why]: Low - This patch adds a null check that was missing. [String/UUID change made/needed]: -
Attachment #8801654 -
Flags: approval-mozilla-aurora?
Comment 7•8 years ago
|
||
Comment on attachment 8801654 [details] Bug 1308631 - UpdateService: Do not apply update without update path. Fix a crash related to update. Take it in 51 aurora.
Attachment #8801654 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
status-firefox51:
--- → affected
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/ee8df4e35218
Updated•8 years ago
|
Iteration: --- → 1.7
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•