1308631 - Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''char[] java.lang.String.toCharArray()'' on a null object reference at java.io.File.fixSlashes(File.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Kevin Brosnan [Ex-Mozilla]]

This bug was filed from the Socorro interface and is 
report bp-debea04f-7219-4322-a7ae-aab9b2161007.
=============================================================

java.lang.NullPointerException: Attempt to invoke virtual method 'char[] java.lang.String.toCharArray()' on a null object reference
	at java.io.File.fixSlashes(File.java:185)
	at java.io.File.<init>(File.java:134)
	at org.mozilla.gecko.updater.UpdateService.onHandleIntent(UpdateService.java:211)
	at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:135)
	at android.os.HandlerThread.run(HandlerThread.java:61)

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

This is high on Aurora. Conflict with the self updater and the Google Play updates?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1308631 - UpdateService: Do not apply update without update path.

Update path can be null. In this case we fallback to using the last saved path. However
if this doesn't exist either then we just continue with a null path and eventually crash
the service.

Review commit: https://reviewboard.mozilla.org/r/86328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86328/

Comment 3

[:Grisha Kruglov]

Comment on attachment 8801654 [details]
Bug 1308631 - UpdateService: Do not apply update without update path.

https://reviewboard.mozilla.org/r/86328/#review85228

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21ce49aa2942
UpdateService: Do not apply update without update path. r=Grisha

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21ce49aa2942

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8801654 [details]
Bug 1308631 - UpdateService: Do not apply update without update path.

Approval Request Comment

[Feature/regressing bug #]: Unknown - The oldest crash reports are from 46.0.

[User impact if declined]: App can crash in rare situations. We saw multiple reports for Aurora coming in lately (Probably because we distribute it via Google Play now and have a bigger audience). That's why I am requesting uplift.

[Describe test coverage new/current, TreeHerder]: Code path can't be tested easily. But patch is simple and straight-forward.

[Risks and why]: Low - This patch adds a null check that was missing.

[String/UUID change made/needed]: -

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8801654 [details]
Bug 1308631 - UpdateService: Do not apply update without update path.

Fix a crash related to update. Take it in 51 aurora.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ee8df4e35218