1308648 - test_css-properties-db.js recommends you run "mach generate-css-db" which is not a valid mach command

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Daniel Holbert [:dholbert]]

test_css-properties-db.js has an error message and some documentation indicating that "mach generate-css-db" is a command that may need to be run.

The problem is, mach generate-css-db isn't a valid command. :)


> $ ./mach generate-css-db
> It looks like you are trying to run an unknown mach command: generate-css-db
> 
> Did you want to run any of these commands instead: devtools-css-db, generate-addon-sdk-moz-build?
> 
> Run |mach help| to show a list of commands.

It looks like the command is actually named "mach devtools-css-db" (not "generate"). We need to correct the test on this.

gtatum, would you mind taking this? Looks like you've been doing some work on this test recently.

Comment 1

[Greg Tatum [:gregtatum]]

Woops, thanks for catching this! I ended up renaming the command, and guess I missed this reference to it in the test. I'll get this fixed.

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1308648 - Fix reference to ./mach devtools-css-db in test_css-properties.js;

Review commit: https://reviewboard.mozilla.org/r/84600/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84600/

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8799408 [details]
Bug 1308648 - Fix reference to ./mach devtools-css-db in test_css-properties.js;

https://reviewboard.mozilla.org/r/84600/#review83142

Thanks.  Looks good.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/273b6a2d3e8d
Fix reference to ./mach devtools-css-db in test_css-properties.js; r=tromey

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/273b6a2d3e8d