1308767 - non removal of account names and passwords when deleting an account

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[ROGER C LUTHER]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160922113459

Steps to reproduce:

I deleted an email account to change a password and change email to an imap from POP3
Setup email address with new password and imap.



Actual results:

I could receive mail but couldn't send 
Not all folders were available
checked saved passwords and found that they had not been deleted when the accout had been deleted, so now there were two passwords for the same account and that the outgoing stmp was using the OLD password so couldn't log in to send mail.
Deleted all passwords for that account. Reset account with new password and all worked


Expected results:

Old account and passwords should have been removed when account was deleted

Comment 1

[Wayne Mery (:wsmwk)]

bug 255948 fixed such an issue in version 3.
perhaps this is a regression?

Comment 2

[:aceman]

I don't think we delete the SMTP server when deleting a mail account. I don't think changing from POP3 to IMAP4 (on the same provider) always means a different SMTP server or password.

But if also the passwords for the receiving account weren't removed, that would be a bug.

But you specified in the bug creation that you are using Thundebird 5.0. Is that correct?

Comment 3

[ROGER C LUTHER]

I am using Thunderbird 45.4.0. That option didn't appear on the initial bug report form.
As I originally stated when the account was removed none of the details for that account were removed from the SAVED PASSWORDS FILE (tools/options/security/passwords)

Comment 4

[:aceman]

It is not a regression. Bug 255948 only halfway works, maybe for imap accounts.
The current implementation tries to delete logins stored as <server type>://hostname . But in password manager we store logins under <localStoreType>://hostname . E.g. for POP3, localStoreType is 'mailbox', not 'pop3'.

Anyway, there is a forgetPassword method of the incomingServer of the account so we can use that one to clear the login. It is also much more specialized (e.g. for News account) than the simplistic method from bug 255948. There is even a test for it in local/test/test_pop3Password3.js .

Comment 5

[:aceman]

Also, deleting SMTP password will be done in bug 1315662.

Comment 6

[:aceman]

Attachment: patch

This should do it.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 8812887 [details] [diff] [review]
patch

Review of attachment 8812887 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 8

[:aceman]

Thanks.

Comment 9

[:aceman]

https://hg.mozilla.org/comm-central/rev/7c40119c6131bc02478fe2bf0417c533bacdd9d0