Closed Bug 1308821 Opened 4 years ago Closed 4 years ago

[EME] keyids initdata format should not have a session type parameter

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The EME spec for keyids initdata format does not specify a session type:
https://w3c.github.io/encrypted-media/format-registry/initdata/keyids.html

But ClearKeyUtils::ParseKeyIdsInitData() is checking for a session type, and assuming a "temporary" session type if no session type is specified. This is one of the cause of the Web Platform Test http://www.w3c-test.org/encrypted-media/clearkey-mp4-playback-destroy-persistent-license.html failing.
Summary: [EME] keyids initdata format should have a session type parameter → [EME] keyids initdata format should not have a session type parameter
Comment on attachment 8799300 [details]
Bug 1308821 - Ensure ClearKey doesn't parse a keyids initdata format session type parameter.

https://reviewboard.mozilla.org/r/84520/#review83352

Looks good to me.
Attachment #8799300 - Flags: review?(kikuo) → review+
The patch here also makes clearkey-mp4-syntax-mediakeysession.html pass.
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b132e52aa0a
Ensure ClearKey doesn't parse a keyids initdata format session type parameter. r=kikuo
Backout by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1834eea3fbce
Backed out changeset 9b132e52aa0a for wpt encrypted-media/clearkey timeouts and unexpected passes
https://hg.mozilla.org/integration/mozilla-inbound/rev/50482ffb2969a1013d3daa2af2924fa3cd86aa75
Bug 1308821 - Ensure ClearKey doesn't parse a keyids initdata format session type parameter. r=kikuo
https://hg.mozilla.org/mozilla-central/rev/50482ffb2969
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.