Closed
Bug 1308821
Opened 8 years ago
Closed 8 years ago
[EME] keyids initdata format should not have a session type parameter
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The EME spec for keyids initdata format does not specify a session type: https://w3c.github.io/encrypted-media/format-registry/initdata/keyids.html But ClearKeyUtils::ParseKeyIdsInitData() is checking for a session type, and assuming a "temporary" session type if no session type is specified. This is one of the cause of the Web Platform Test http://www.w3c-test.org/encrypted-media/clearkey-mp4-playback-destroy-persistent-license.html failing.
|
Assignee | |
Updated•8 years ago
|
Summary: [EME] keyids initdata format should have a session type parameter → [EME] keyids initdata format should not have a session type parameter
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8799300 [details] Bug 1308821 - Ensure ClearKey doesn't parse a keyids initdata format session type parameter. https://reviewboard.mozilla.org/r/84520/#review83352 Looks good to me.
Attachment #8799300 -
Flags: review?(kikuo) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
The patch here also makes clearkey-mp4-syntax-mediakeysession.html pass.
Pushed by cpearce@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9b132e52aa0a Ensure ClearKey doesn't parse a keyids initdata format session type parameter. r=kikuo
Backout by philringnalda@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1834eea3fbce Backed out changeset 9b132e52aa0a for wpt encrypted-media/clearkey timeouts and unexpected passes
|
||
Comment 6•8 years ago
|
||
e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=5716097&repo=autoland
|
|
Assignee | |
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/50482ffb2969a1013d3daa2af2924fa3cd86aa75 Bug 1308821 - Ensure ClearKey doesn't parse a keyids initdata format session type parameter. r=kikuo
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/50482ffb2969
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•