1308821 - [EME] keyids initdata format should not have a session type parameter

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

The EME spec for keyids initdata format does not specify a session type:
https://w3c.github.io/encrypted-media/format-registry/initdata/keyids.html

But ClearKeyUtils::ParseKeyIdsInitData() is checking for a session type, and assuming a "temporary" session type if no session type is specified. This is one of the cause of the Web Platform Test http://www.w3c-test.org/encrypted-media/clearkey-mp4-playback-destroy-persistent-license.html failing.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1308821 - Ensure ClearKey doesn't parse a keyids initdata format session type parameter.

The specification doesn't require there to be a 'type' member of
the keyids init data format.

Review commit: https://reviewboard.mozilla.org/r/84520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84520/

Comment 2

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8799300 [details]
Bug 1308821 - Ensure ClearKey doesn't parse a keyids initdata format session type parameter.

https://reviewboard.mozilla.org/r/84520/#review83352

Looks good to me.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

The patch here also makes clearkey-mp4-syntax-mediakeysession.html pass.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b132e52aa0a
Ensure ClearKey doesn't parse a keyids initdata format session type parameter. r=kikuo

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1834eea3fbce
Backed out changeset 9b132e52aa0a for wpt encrypted-media/clearkey timeouts and unexpected passes

Comment 6

[Phil Ringnalda (:philor)]

e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=5716097&repo=autoland

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50482ffb2969a1013d3daa2af2924fa3cd86aa75
Bug 1308821 - Ensure ClearKey doesn't parse a keyids initdata format session type parameter. r=kikuo

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/50482ffb2969