Implement minimal Redux store for Net panel

RESOLVED FIXED in Firefox 52

Status

P1
normal
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: Honza, Assigned: rickychien)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 52
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [netmonitor])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The panel state (e.g. current filter, list of HTTP request, etc.) should be stored in a Redux store object. This bug should implement/introduce minimal version of the store so, we can start adding data/state into it (as part of other bug reports).

Honza
(Reporter)

Updated

2 years ago
Blocks: 1308426
(Assignee)

Updated

2 years ago
Assignee: nobody → rchien
Status: NEW → ASSIGNED

Updated

2 years ago
Blocks: 1307743

Updated

2 years ago
Whiteboard: [netmonitor]

Updated

2 years ago
Flags: qe-verify-
(Assignee)

Comment 1

2 years ago
It's hard to figure out application state at the beginning, so I prefer to create an empty initial store here. Everyone has started creating component should add new state into redux store for net panel.
(Reporter)

Comment 2

2 years ago
(In reply to Ricky Chien [:rickychien] from comment #1)
> It's hard to figure out application state at the beginning, so I prefer to
> create an empty initial store here. Everyone has started creating component
> should add new state into redux store for net panel.
Yes, agree.

Honza
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8800191 - Flags: review?(odvarko)
Comment hidden (mozreview-request)
(Assignee)

Comment 5

2 years ago
I just created initial setups for redux and also created folder structure we need eventually for redux.
(Reporter)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8800191 [details]
Bug 1308878 - Implement minimal Redux store for Net panel

https://reviewboard.mozilla.org/r/85188/#review83802

I like it, thanks for doing this!

R+

Just to note that ther is defeault createStore() implemented in 'devtools/client/shared/redux/create-store' module. At some point we might want to use it.

Honza
Attachment #8800191 - Flags: review?(odvarko) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 8

2 years ago
The default create-store is nice! I modified my patch to use it and everything is ready.
seems this had conflicts when i tried to land this via autoland -> js warning: conflicts while merging devtools/client/netmonitor/moz.build! (edit, then use 'hg resolve --mark') warning: conflicts while merging devtools/client/netmonitor/netmonitor-view.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue) 

could you take a look, thanks!
Flags: needinfo?(rchien)
Comment hidden (mozreview-request)
Conflicts has been addressed! thanks!
Flags: needinfo?(rchien) → needinfo?(cbook)

Comment 12

2 years ago
mozreview-review
Comment on attachment 8800191 [details]
Bug 1308878 - Implement minimal Redux store for Net panel

https://reviewboard.mozilla.org/r/85188/#review84078

::: devtools/client/netmonitor/har/moz.build
(Diff revision 3)
>      'har-exporter.js',
>      'har-utils.js',
>      'toolbox-overlay.js',
>  )
> -
> -BROWSER_CHROME_MANIFESTS += ['test/browser.ini']

Is it intended or why need remove this line?
(Assignee)

Comment 13

2 years ago
mozreview-review-reply
Comment on attachment 8800191 [details]
Bug 1308878 - Implement minimal Redux store for Net panel

https://reviewboard.mozilla.org/r/85188/#review84078

> Is it intended or why need remove this line?

Thanks for reminding that. I've reverted
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
thanks, triggered the landing via autoland!
Flags: needinfo?(cbook)
Comment hidden (mozreview-request)
Autoland couldn't rebase this.
Keywords: checkin-needed
Comment hidden (mozreview-request)
Ryan, I just rebased and fixed new conflicts again. I think it's ready :P
Flags: needinfo?(ryanvm)
Flags: needinfo?(ryanvm)

Comment 21

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/797b8b501271
Implement minimal Redux store for Net panel r=Honza

Updated

2 years ago
Priority: -- → P1

Comment 22

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/797b8b501271
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Updated

2 years ago
Iteration: --- → 52.2 - Oct 17

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.