Closed Bug 1308878 Opened 8 years ago Closed 8 years ago

Implement minimal Redux store for Net panel

Categories

(DevTools :: Netmonitor, defect, P1)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Iteration:
52.2 - Oct 17
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: Honza, Assigned: rickychien)

References

(Blocks 1 open bug)

Details

(Whiteboard: [netmonitor])

Attachments

(1 file)

Bug 1308878 - Implement minimal Redux store for Net panel
58 bytes, text/x-review-board-request
Honza
: review+
Details
The panel state (e.g. current filter, list of HTTP request, etc.) should be stored in a Redux store object. This bug should implement/introduce minimal version of the store so, we can start adding data/state into it (as part of other bug reports). Honza
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Whiteboard: [netmonitor]
Flags: qe-verify-
It's hard to figure out application state at the beginning, so I prefer to create an empty initial store here. Everyone has started creating component should add new state into redux store for net panel.
(In reply to Ricky Chien [:rickychien] from comment #1) > It's hard to figure out application state at the beginning, so I prefer to > create an empty initial store here. Everyone has started creating component > should add new state into redux store for net panel. Yes, agree. Honza
Attachment #8800191 - Flags: review?(odvarko)
I just created initial setups for redux and also created folder structure we need eventually for redux.
Comment on attachment 8800191 [details] Bug 1308878 - Implement minimal Redux store for Net panel https://reviewboard.mozilla.org/r/85188/#review83802 I like it, thanks for doing this! R+ Just to note that ther is defeault createStore() implemented in 'devtools/client/shared/redux/create-store' module. At some point we might want to use it. Honza
Attachment #8800191 - Flags: review?(odvarko) → review+
The default create-store is nice! I modified my patch to use it and everything is ready.
seems this had conflicts when i tried to land this via autoland -> js warning: conflicts while merging devtools/client/netmonitor/moz.build! (edit, then use 'hg resolve --mark') warning: conflicts while merging devtools/client/netmonitor/netmonitor-view.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue) could you take a look, thanks!
Flags: needinfo?(rchien)
Conflicts has been addressed! thanks!
Flags: needinfo?(rchien) → needinfo?(cbook)
Comment on attachment 8800191 [details] Bug 1308878 - Implement minimal Redux store for Net panel https://reviewboard.mozilla.org/r/85188/#review84078 ::: devtools/client/netmonitor/har/moz.build (Diff revision 3) > 'har-exporter.js', > 'har-utils.js', > 'toolbox-overlay.js', > ) > - > -BROWSER_CHROME_MANIFESTS += ['test/browser.ini'] Is it intended or why need remove this line?
Comment on attachment 8800191 [details] Bug 1308878 - Implement minimal Redux store for Net panel https://reviewboard.mozilla.org/r/85188/#review84078 > Is it intended or why need remove this line? Thanks for reminding that. I've reverted
thanks, triggered the landing via autoland!
Flags: needinfo?(cbook)
Autoland couldn't rebase this.
Keywords: checkin-needed
Ryan, I just rebased and fixed new conflicts again. I think it's ready :P
Flags: needinfo?(ryanvm)
Flags: needinfo?(ryanvm)
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/797b8b501271 Implement minimal Redux store for Net panel r=Honza
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/797b8b501271
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Iteration: --- → 52.2 - Oct 17
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: