1308906 - TraceLogger: Rename Internal to TraceLogger

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Hannes Verschore [:h4writer]]

I often get the question what "Internal" is. Seems like "Internal" is confused by internal js time, instead of internal tracelogger time. I will just rename it to "TraceLogger" instead. That will make it more obvious.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Patch

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8799727 [details] [diff] [review]
Patch

Review of attachment 8799727 [details] [diff] [review]:
-----------------------------------------------------------------

Yay for Tracelogger UX!

::: js/src/vm/TraceLoggingTypes.h
@@ +97,5 @@
>      switch (id) {
>        case TraceLogger_Error:
>          return "TraceLogger failed to process text";
> +      case TraceLogger_Internal:
> +        return "TraceLogger";

Could it be even more precise, like "TraceLogger overhead", or "Tracelogger internal"?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bb32ec5b75b
TraceLogger - Make sure it is more clear what internal time in TraceLogger means, r=bbouvier

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4bb32ec5b75b