Closed Bug 1308934 Opened 4 years ago Closed 4 years ago

Change csv file attachment on Mozilla Reps Swag Request

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: kiki, Assigned: seban, Mentored)

Details

Attachments

(2 files)

636 bytes, text/csv
Details
44 bytes, text/x-github-pull-request
dylan
: review+
Details | Review
Attached file swagform.csv
Hi all, 

Since our department is change into Participation team & we also need to change the requester, I'm opening this bug to change the CSV file in the swag request. The updated CSV file is attached. Please, do let me know if you need any other info. 

Thanks in advance.
Hi Rizki!

I am assigning this to our #1 BMO volunteer. He will probably followup with some needinfos.
I'll still be following the bug and advising Sebastin as needed. This bug is in capable hands.

Cheers,
Dylan.
Assignee: nobody → sebastinssanty
Mentor: dylan
Hi Dylan, 

thanks for assigning this so quick. I'm putting Konstantina in the cc here as she can also probably provide the info that will needed. 

Once again, thanks for the help!
Kiki
Attached file patch
Hi Rizki/Konstantina,

I assume, you just want the order of the fields to be changed. Do revert back if it is not the case. Nevertheless, I have submitted a patch.
Flags: needinfo?(kelimutu)
Attachment #8799614 - Flags: review?(dylan)
Hi Sebastin,

No, we're not changing the order. Basically, we're only changing some fields in the current CSV file with the new one which is attached in this bug.
Flags: needinfo?(kelimutu)
This is one of the tricker forms, I should've given you more detail. :-)

This form creates a CSV attachment with specific data from the form request.
Because I wrote it, it's very general and maybe a bit over-engineered...

To add or change fields in the CSV, you'll need to edit
this hash:

https://github.com/mozilla-bteam/bmo/blob/master/extensions/REMO/Extension.pm#L185-L217

How this works is... each of the keys becomes a column in the CSV file,
the pos item controls the ordering, and value (if specified) provides a default value
for the field. If the value is a string, like '%shiptofirstname%', it will use the value from
the form. If the value is a subroutine, it will call it (example: https://github.com/mozilla-bteam/bmo/blob/master/extensions/REMO/Extension.pm#L208)
Comment on attachment 8799614 [details] [review]
patch

Hey, can you take a look at this soon?
It should be just a matter of changing the values
in %CSV_COLUMNS in extensions/REMO/Extension.pm
Flags: needinfo?(sebastinssanty)
Attachment #8799614 - Flags: review?(dylan) → review-
Yes, I'll try to do it by tomorrow
Flags: needinfo?(sebastinssanty)
May I know the progress here?
Comment on attachment 8799614 [details] [review]
patch

Hi Rizki,

Sorry for the delay. It depended on Bug 1308942, being merged.

Dylan: Can you please review this?
Attachment #8799614 - Flags: review- → review?(dylan)
To git@github.com:mozilla-bteam/bmo.git
   8de8d61..1adc638  master -> master
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8799614 [details] [review]
patch

r=dylan
Attachment #8799614 - Flags: review?(dylan) → review+
Form changes are live now.

dkl
Awesome. Thanks, everyone. (:
Component: Extensions: REMO → Extensions
You need to log in before you can comment on or make changes to this bug.