1308934 - Change csv file attachment on Mozilla Reps Swag Request

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Kelimutu [:kiki]]

Attachment: swagform.csv

Hi all, 

Since our department is change into Participation team & we also need to change the requester, I'm opening this bug to change the CSV file in the swag request. The updated CSV file is attached. Please, do let me know if you need any other info. 

Thanks in advance.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Hi Rizki!

I am assigning this to our #1 BMO volunteer. He will probably followup with some needinfos.
I'll still be following the bug and advising Sebastin as needed. This bug is in capable hands.

Cheers,
Dylan.

Comment 2

[Kelimutu [:kiki]]

Hi Dylan, 

thanks for assigning this so quick. I'm putting Konstantina in the cc here as she can also probably provide the info that will needed. 

Once again, thanks for the help!
Kiki

Comment 3

[Sebastin Santy [:seban]]

Attachment: patch

Hi Rizki/Konstantina,

I assume, you just want the order of the fields to be changed. Do revert back if it is not the case. Nevertheless, I have submitted a patch.

Comment 4

[Kelimutu [:kiki]]

Hi Sebastin,

No, we're not changing the order. Basically, we're only changing some fields in the current CSV file with the new one which is attached in this bug.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

This is one of the tricker forms, I should've given you more detail. :-)

This form creates a CSV attachment with specific data from the form request.
Because I wrote it, it's very general and maybe a bit over-engineered...

To add or change fields in the CSV, you'll need to edit
this hash:

https://github.com/mozilla-bteam/bmo/blob/master/extensions/REMO/Extension.pm#L185-L217

How this works is... each of the keys becomes a column in the CSV file,
the pos item controls the ordering, and value (if specified) provides a default value
for the field. If the value is a string, like '%shiptofirstname%', it will use the value from
the form. If the value is a subroutine, it will call it (example: https://github.com/mozilla-bteam/bmo/blob/master/extensions/REMO/Extension.pm#L208)

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8799614 [details] [review]
patch

Hey, can you take a look at this soon?
It should be just a matter of changing the values
in %CSV_COLUMNS in extensions/REMO/Extension.pm

Comment 7

[Sebastin Santy [:seban]]

Yes, I'll try to do it by tomorrow

Comment 8

[Kelimutu [:kiki]]

May I know the progress here?

Comment 9

[Sebastin Santy [:seban]]

Comment on attachment 8799614 [details] [review]
patch

Hi Rizki,

Sorry for the delay. It depended on Bug 1308942, being merged.

Dylan: Can you please review this?

Comment 10

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   8de8d61..1adc638  master -> master

Comment 11

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8799614 [details] [review]
patch

r=dylan

Comment 12

[David Lawrence [:dkl]]

Form changes are live now.

dkl

Comment 13

[Kelimutu [:kiki]]

Awesome. Thanks, everyone. (: