separate system add-ons from extensions in about:support

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
General
RESOLVED FIXED
10 months ago
4 months ago

People

(Reporter: rhelmer, Assigned: mossop)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
Right now system add-ons appear alongside normal extensions in about:support.

We should put these in a separate section, with a header like "Application Components" or something along those lines, so it's clear that these are built-in.

Comment 1

10 months ago
about:support lives in toolkit.
Component: General → General
Product: Firefox → Toolkit
Since we'll be touching this, could we add a new column for these system add-ons that says either "built-in" or "updated"? This would help both the QA process, and also to debug reports from users in the wild.
(Assignee)

Updated

5 months ago
Assignee: rhelmer → dtownsend
(Assignee)

Comment 3

5 months ago
(In reply to :Felipe Gomes (needinfo me!) from comment #2)
> Since we'll be touching this, could we add a new column for these system
> add-ons that says either "built-in" or "updated"? This would help both the
> QA process, and also to debug reports from users in the wild.

This isn't trivial to do. Can we not just compare version numbers?
Flags: needinfo?(felipc)
Comment hidden (mozreview-request)
I'm fine with not doing this here, but it'd be nice to leave a bug open for that at least. The trick is figuring out the version number that shipped in past Firefox versions (when we're writing a system addon for a previous version to fix something).. Sure it's not hard but it's still some work.

There's some work planned to publish a list of these versions somewhere (bug 1311105), but I don't know when that will be done.
Flags: needinfo?(felipc)
(Assignee)

Updated

4 months ago
Attachment #8845679 - Flags: review?(rhelmer)
(Reporter)

Comment 6

4 months ago
(In reply to Dave Townsend [:mossop] from comment #3)
> (In reply to :Felipe Gomes (needinfo me!) from comment #2)
> > Since we'll be touching this, could we add a new column for these system
> > add-ons that says either "built-in" or "updated"? This would help both the
> > QA process, and also to debug reports from users in the wild.
> 
> This isn't trivial to do. Can we not just compare version numbers?


(In reply to :Felipe Gomes (needinfo me!) from comment #5)
> I'm fine with not doing this here, but it'd be nice to leave a bug open for
> that at least. The trick is figuring out the version number that shipped in
> past Firefox versions (when we're writing a system addon for a previous
> version to fix something).. Sure it's not hard but it's still some work.
> 
> There's some work planned to publish a list of these versions somewhere (bug
> 1311105), but I don't know when that will be done.

I don't think `about:support` itself needs to know anything about version numbers, besides just exposing what is installed.

AddonManager knows if the add-on is in the built-in or the update location, it's not exposed on the public Addon object - we could do so though (`isBuiltIn` getter for instance - so `(addon.isSystem && !addon.isBuiltIn)` would be a system add-on update)

Let's do a follow-up, something like the above would keep the `about:support` side simple.
(Reporter)

Comment 7

4 months ago
mozreview-review
Comment on attachment 8845679 [details]
Bug 1308981: Display system add-ons in a separate section in about:support.

https://reviewboard.mozilla.org/r/118828/#review121780

lgtm. I like the use of the word "features" for the UI.
(Assignee)

Comment 8

4 months ago
mozreview-review
Comment on attachment 8845679 [details]
Bug 1308981: Display system add-ons in a separate section in about:support.

https://reviewboard.mozilla.org/r/118830/#review122586

I believe that rhelmer meant to r+ this
Attachment #8845679 - Flags: review+

Comment 9

4 months ago
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eda5d5658dde
Display system add-ons in a separate section in about:support. r=rhelmer

Comment 10

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/eda5d5658dde
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Reporter)

Comment 11

4 months ago
mozreview-review
Comment on attachment 8845679 [details]
Bug 1308981: Display system add-ons in a separate section in about:support.

https://reviewboard.mozilla.org/r/118830/#review122990
Attachment #8845679 - Flags: review?(rhelmer) → review+
You need to log in before you can comment on or make changes to this bug.