1308993 - 1,100 instances of "NYI: align-self:left/right/self-start/self-end/last-baseline" emitted from layout/generic/nsFlexContainerFrame.cpp during linux64 debug testing

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect)

Description

[Eric Rahm [:erahm]]

> 1105 WARNING: NYI: align-self:left/right/self-start/self-end/last-baseline: file layout/generic/nsFlexContainerFrame.cpp, line 3125

This warning [1] shows up in the following test suites:

>   1105 - desktop-test-linux64/debug-mochitest-devtools-chrome-2 dt2

It shows up in 17 tests. A few of the most prevalent:

>    208 -        devtools/client/aboutdebugging/test/browser_addons_debugging_initial_state.js
>    176 -        devtools/client/aboutdebugging/test/browser_addons_reload.js
>     92 -        devtools/client/aboutdebugging/test/browser_addons_debug_bootstrapped.js
>     92 -        devtools/client/aboutdebugging/test/browser_addons_install.js
>     80 -        devtools/client/aboutdebugging/test/browser_page_not_found.js
>     52 -        devtools/client/aboutdebugging/test/browser_addons_toggle_debug.js
>     52 -        devtools/client/aboutdebugging/test/browser_addons_debug_webextension_nobg.js
>     52 -        devtools/client/aboutdebugging/test/browser_addons_debug_webextension_inspector.js
>     52 -        devtools/client/aboutdebugging/test/browser_addons_debug_webextension.js
>     52 -        devtools/client/aboutdebugging/test/browser_addons_debug_webextension_popup.js

[1] https://hg.mozilla.org/mozilla-central/annotate/7be6b348c431/layout/generic/nsFlexContainerFrame.cpp#l3125

Comment 1

[Daniel Holbert [:dholbert]]

I guess devtools tests must be exercising these unimplemented-in-layout values...?

In any case: left/right are implemented in bug 1221565, so that patch should reduce this a bit. And bug 1221525 is where we'll implement "last-baseline".  I don't know that we have a bug for "self-start"/"self-end" yet, but they're under the umbrella of bug 1207698, so I'll add that as a dependency for now.

Comment 2

[Patrick Brosset <:pbro>]

I did a quick search in devtools code and couldn't find instances of
`align-self: left` or `align-self: right` or `align-self: self-start` or `align-self: self-end` or `align-self: last-baseline`.

Are there any other declarations that may cause this warning? If we use unimplemented values, we should just get rid of them, right?

Comment 3

[Julian Descottes [:jdescottes]]

The warnings are actually coming from :

> align-items: self-start;

at http://searchfox.org/mozilla-central/rev/2142de26c16c05f23e543be4fa1a651c4d29604e/devtools/client/aboutdebugging/aboutdebugging.css#64

We should use align-items: start; instead. I will fix this in about:debugging.
I think we should also update the warning message to be "WARNING: NYI: align-items/align-self:left/right/self-start/self-end/last-baseline".

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1308993 - aboutdebugging remove align-items: self-start;

Review commit: https://reviewboard.mozilla.org/r/85572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85572/

Comment 5

[Daniel Holbert [:dholbert]]

The layout/generic/nsFlexContainerFrame.cpp warning-message changes seem fine to me, BTW. Thanks for getting to the bottom of this.

Comment 6

[Eric Rahm [:erahm]]

Comment on attachment 8800690 [details]
Bug 1308993 - aboutdebugging remove align-items: self-start;

https://reviewboard.mozilla.org/r/85572/#review84246

Comment 7

[Eric Rahm [:erahm]]

Comment on attachment 8800690 [details]
Bug 1308993 - aboutdebugging remove align-items: self-start;

https://reviewboard.mozilla.org/r/85572/#review84248

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03c8f8c92055
aboutdebugging remove align-items: self-start;r=erahm

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/03c8f8c92055