1308995 - Remove nsTracerefcnt infrastructure that exists only to support about:bloat

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Comment 1

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=49f7ada15c94

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1308995, part 1 - Remove unused DumpStatistics::aOut argument.

Only about:bloat used this argument.

Review commit: https://reviewboard.mozilla.org/r/84902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84902/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1308995, part 2 - Remove nsTraceRefcnt::StatisticsType arguments.

Only about:bloat used NEW_STATS, so act like we have ALL_STATS
everywhere. A later patch will remove the mNewStats field.

Review commit: https://reviewboard.mozilla.org/r/84904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84904/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1308995, part 3 - Get rid of mNewStats.

Nobody asks for the new stats, only the total ones, so there's no need
for two sets of statistics.

Review commit: https://reviewboard.mozilla.org/r/84906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84906/

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1308995, part 4 - Rename mAllStats to mStats.

There's only one stats field now.

Review commit: https://reviewboard.mozilla.org/r/84908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84908/

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: Bug 1308995, part 5 - Use early return in NS_LogCtor/Dtor.

This is an unrelated change to fix an issue that was bothering me.

Review commit: https://reviewboard.mozilla.org/r/84910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84910/

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 8799783 [details]
Bug 1308995, part 1 - Remove unused DumpStatistics::aOut argument.

https://reviewboard.mozilla.org/r/84902/#review83448

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8799784 [details]
Bug 1308995, part 2 - Remove nsTraceRefcnt::StatisticsType arguments.

https://reviewboard.mozilla.org/r/84904/#review83450

Comment 9

[Nathan Froyd [:froydnj]]

Comment on attachment 8799785 [details]
Bug 1308995, part 3 - Get rid of mNewStats.

https://reviewboard.mozilla.org/r/84906/#review83454

Comment 10

[Nathan Froyd [:froydnj]]

Comment on attachment 8799786 [details]
Bug 1308995, part 4 - Rename mAllStats to mStats.

https://reviewboard.mozilla.org/r/84908/#review83456

Comment 11

[Nathan Froyd [:froydnj]]

Comment on attachment 8799787 [details]
Bug 1308995, part 5 - Use early return in NS_LogCtor/Dtor.

https://reviewboard.mozilla.org/r/84910/#review83458

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44731781b62e
part 1 - Remove unused DumpStatistics::aOut argument. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/cd8b426e2192
part 2 - Remove nsTraceRefcnt::StatisticsType arguments. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/282f1c21beeb
part 3 - Get rid of mNewStats. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/2aeb18b3df71
part 4 - Rename mAllStats to mStats. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/07516ea470af
part 5 - Use early return in NS_LogCtor/Dtor. r=froydnj

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44731781b62e
https://hg.mozilla.org/mozilla-central/rev/cd8b426e2192
https://hg.mozilla.org/mozilla-central/rev/282f1c21beeb
https://hg.mozilla.org/mozilla-central/rev/2aeb18b3df71
https://hg.mozilla.org/mozilla-central/rev/07516ea470af