1309014 - Update whitespace text nodes visibility in the inspector on reflow

Status: NEW

Description

[Patrick Brosset <:pbro>]

Created attachment 8799493 [details]
whitespace-spacing-issues.html

STR:

- have the patch in bug 1304685 applied locally, or wait for it to land
- open the test case HTML file
- open the inspector
- open the <span> element and check the list of children displayed in the inspector
==> you should see whitespace text nodes displayed in there
- now, still with the <span> selected, add the following CSS property: white-space:pre;

Expected: because this property updates the way text is laid out and how whitespace-only text nodes collapse, a reflow occurs and the content of the span is laid out again. As a result, more whitespace text nodes actually influence the layout, so the list of nodes shown in the inspector should update to reflect this.

Actual: The list of text nodes in the inspector doesn't change.

More info about whitespace processing here: https://www.w3.org/TR/css-text-3/#white-space-processing

Potential solution: listen to reflow events (we have a ReflowActor that is used already in a couple of places in devtools). This doesn't mean we should refresh the whole markup-view every time a reflow occurs either, we need a way to know when reflows actually change what is shown in the markup-view.

Right now, the only for this view to update is when markup mutations occur. In the present case, there are no mutations, it's just a layout change that impacts what is shown in the view.

Comment 1

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).