1309047 - Identity icon isn't properly updated for the initially selected heuristic result

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect, P3)

Description

[Drew Willcoxon :adw]

Matthew noticed this problem with the omnibox magic word API he's working on.  The identity icon in the urlbar isn't properly updated for the initially selected result.  It remains an info icon until you re-select the heuristic result, for example by arrowing down and then back up to it.

I thought there was already a bug on file for this, but I couldn't find one.  I guess it hasn't been a big problem because we haven't had a use case where the heuristic result should drastically change the style/appearance of the urlbar, like switch-to-tab and now omnibox results do.

Comment 1

[Marco Bonardo [:mak]]

Bug 1306639 solves a part of this in the backend. The problem is probably the fact we do the preselection in the frontend and we don't hit all the code paths of a normal selection. I also think we skip some of that for accessibility (IIRC) so that it keeps seeing the input field as focused.

Comment 2

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 3

[Marco Bonardo [:mak]]

Not sure if this is still relevant, since on focus we remove all the entities from the input field.

Comment 4

[Marco Bonardo [:mak]]

doesn't seem to apply anymore