1309079 - implement mp3-in-mp4 spec in the rust mp4 parser

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alfredo Yang (:alfredo)]

Support mp3 in rust mp4 parser.

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: small-shot-mp3.mp4

test file

Comment 2

[Alfredo Yang (:alfredo)]

This is from test_autoplay_contentEditable.html.

Comment 3

[Alfredo Yang (:alfredo)]

https://github.com/mozilla/mp4parse-rust/pull/38

Comment 4

[Alfredo Yang (:alfredo)]

Attachment: Bug 1309079 - support mp3-in-mp4 in rust mp4 parser.

Review commit: https://reviewboard.mozilla.org/r/85406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85406/

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8800494 [details]
Bug 1309079 - support mp3-in-mp4 in rust mp4 parser.

https://reviewboard.mozilla.org/r/85406/#review83986

Comment 6

[Alfredo Yang (:alfredo)]

(In reply to Matthew Gregan [:kinetik] from comment #5)
> Comment on attachment 8800494 [details]
> Bug 1309079 - support mp3-in-mp4 in rust mp4 parser.
> 
> https://reviewboard.mozilla.org/r/85406/#review83986

Thanks for quick review!

Comment 7

[Alfredo Yang (:alfredo)]

Comment on attachment 8800494 [details]
Bug 1309079 - support mp3-in-mp4 in rust mp4 parser.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85406/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b530816adfc
support mp3-in-mp4 in rust mp4 parser. r=kinetik

Comment 9

[Alfredo Yang (:alfredo)]

Upstream mp4rust updated to gecko in bug 1303888.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b530816adfc