Closed Bug 1309079 Opened 3 years ago Closed 3 years ago

implement mp3-in-mp4 spec in the rust mp4 parser

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: ayang, Assigned: ayang)

References

Details

Attachments

(2 files)

small-shot-mp3.mp4
7.32 KB, video/mp4
Details
Bug 1309079 - support mp3-in-mp4 in rust mp4 parser.
58 bytes, text/x-review-board-request
kinetik
: review+
Details 
Support mp3 in rust mp4 parser.
Assignee: nobody → ayang
Summary: Support mp3 audio in mp4 rust parse → implement mp3-in-mp4 spec in the rust mp4 parser
Attached video small-shot-mp3.mp4 — 
test file
This is from test_autoplay_contentEditable.html.
Comment on attachment 8800494 [details]
Bug 1309079 - support mp3-in-mp4 in rust mp4 parser.

https://reviewboard.mozilla.org/r/85406/#review83986
Attachment #8800494 - Flags: review?(kinetik) → review+
Blocks: 1161350
(In reply to Matthew Gregan [:kinetik] from comment #5)
> Comment on attachment 8800494 [details]
> Bug 1309079 - support mp3-in-mp4 in rust mp4 parser.
> 
> https://reviewboard.mozilla.org/r/85406/#review83986

Thanks for quick review!
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b530816adfc
support mp3-in-mp4 in rust mp4 parser. r=kinetik
Upstream mp4rust updated to gecko in bug 1303888.
https://hg.mozilla.org/mozilla-central/rev/3b530816adfc
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.