Web manifest's window.oninstall renamed "onappinstalled"

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: marcosc, Assigned: marcosc)

Tracking

(Blocks 1 bug, {dev-doc-complete})

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

()

Attachments

(1 attachment, 1 obsolete attachment)

To avoid confusion with service worker's install event, the Web Manifest's "install" event got renamed to "appinstalled".
Assignee: nobody → mcaceres
This is literally just a rename of an event from "install" to "onappinstalled".

Sorry qDot - word's most boring review... thought hopefully quick.
Attachment #8799606 - Flags: review?(kyle)
Attachment #8799606 - Flags: review?(kyle) → review+
Attachment #8799606 - Attachment is obsolete: true
Keywords: checkin-needed
need dom peer review for the change in dom/webidl/Window.webidl
Flags: needinfo?(mcaceres)
Keywords: checkin-needed
I think qDot is a DOM peer. See: https://twitter.com/qDot/status/783406299992031232

Maybe he didn't click the right buttons somewhere?
Flags: needinfo?(mcaceres) → needinfo?(cbook)
Kyle, can you file a bug to update http://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hghooks/mozhghooks/prevent_webidl_changes.py ?
Flags: needinfo?(cbook) → needinfo?(kyle)
Carsten, sorry... unrelated (kinda), but there are a lot of names in that list of people who no longer work at Mozilla. Does that matter?
Flags: needinfo?(cbook)
(In reply to Marcos Caceres [:marcosc] from comment #7)
> Carsten, sorry... unrelated (kinda), but there are a lot of names in that
> list of people who no longer work at Mozilla. Does that matter?

i think that it does not depend on a employment status to be dom peer (also this would exclude per default community) and so a non-employee can be dom-peer - only if someone decide that if someone leave he/she would have no time to be dom peer anymore someone can resign from this role.
Flags: needinfo?(cbook)
(In reply to Carsten Book [:Tomcat] from comment #8)
> i think that it does not depend on a employment status to be dom peer (also
> this would exclude per default community) and so a non-employee can be
> dom-peer - only if someone decide that if someone leave he/she would have no
> time to be dom peer anymore someone can resign from this role.

Make sense. Thanks!
Bug 1309644 filed. I'll land this once that's and deployed.
Flags: needinfo?(kyle)
Pushed by kmachulis@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72ecc0c64b13
Web manifest's window.oninstall renamed onappinstalled. r=qdot
Ok, bug 1309644 resolved, pushed this patch cleanly with me as a reviewer and peer now.
https://hg.mozilla.org/mozilla-central/rev/72ecc0c64b13
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
I see the docs have mostly been done already (thanks Marcos!); I've just done a bit of cleanup.

Moved the hander page to the correct URL:
https://developer.mozilla.org/en-US/docs/Web/API/Window/onappinstalled

Updated the event page:
https://developer.mozilla.org/en-US/docs/Web/Events/appinstalled

Updated the entry in the Window index listing:
https://developer.mozilla.org/en-US/docs/Web/API/Window#Event_handlers

Added an entry for the event to the events reference:
https://developer.mozilla.org/en-US/docs/Web/Events

I also added a note to the Fx 52 release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/52#DOM_HTML_DOM

Let me know if that's OK. Thanks!
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.