1309099 - Web manifest's window.oninstall renamed "onappinstalled"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Marcos Caceres [:marcosc]]

To avoid confusion with service worker's install event, the Web Manifest's "install" event got renamed to "appinstalled".

Comment 1

[Marcos Caceres [:marcosc]]

Attachment: 0001-Bug-1309099-Web-manifest-s-window.oninstall-renamed-.patch

This is literally just a rename of an event from "install" to "onappinstalled".

Sorry qDot - word's most boring review... thought hopefully quick.

Comment 2

[Marcos Caceres [:marcosc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ecdf276dcc9

Comment 3

[Marcos Caceres [:marcosc]]

Attachment: Added qDot as reviewer

Comment 4

[Carsten Book [:Tomcat]]

need dom peer review for the change in dom/webidl/Window.webidl

Comment 5

[Marcos Caceres [:marcosc]]

I think qDot is a DOM peer. See: https://twitter.com/qDot/status/783406299992031232

Maybe he didn't click the right buttons somewhere?

Comment 6

[Carsten Book [:Tomcat]]

Kyle, can you file a bug to update http://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hghooks/mozhghooks/prevent_webidl_changes.py ?

Comment 7

[Marcos Caceres [:marcosc]]

Carsten, sorry... unrelated (kinda), but there are a lot of names in that list of people who no longer work at Mozilla. Does that matter?

Comment 8

[Carsten Book [:Tomcat]]

(In reply to Marcos Caceres [:marcosc] from comment #7)
> Carsten, sorry... unrelated (kinda), but there are a lot of names in that
> list of people who no longer work at Mozilla. Does that matter?

i think that it does not depend on a employment status to be dom peer (also this would exclude per default community) and so a non-employee can be dom-peer - only if someone decide that if someone leave he/she would have no time to be dom peer anymore someone can resign from this role.

Comment 9

[Marcos Caceres [:marcosc]]

(In reply to Carsten Book [:Tomcat] from comment #8)
> i think that it does not depend on a employment status to be dom peer (also
> this would exclude per default community) and so a non-employee can be
> dom-peer - only if someone decide that if someone leave he/she would have no
> time to be dom peer anymore someone can resign from this role.

Make sense. Thanks!

Comment 10

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Bug 1309644 filed. I'll land this once that's and deployed.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72ecc0c64b13
Web manifest's window.oninstall renamed onappinstalled. r=qdot

Comment 12

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Ok, bug 1309644 resolved, pushed this patch cleanly with me as a reviewer and peer now.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72ecc0c64b13

Comment 14

[Chris Mills [:cmills]]

I see the docs have mostly been done already (thanks Marcos!); I've just done a bit of cleanup.

Moved the hander page to the correct URL:
https://developer.mozilla.org/en-US/docs/Web/API/Window/onappinstalled

Updated the event page:
https://developer.mozilla.org/en-US/docs/Web/Events/appinstalled

Updated the entry in the Window index listing:
https://developer.mozilla.org/en-US/docs/Web/API/Window#Event_handlers

Added an entry for the event to the events reference:
https://developer.mozilla.org/en-US/docs/Web/Events

I also added a note to the Fx 52 release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/52#DOM_HTML_DOM

Let me know if that's OK. Thanks!