1309157 - conversion-native-function.js test expects hypot() in libc while it's in libm

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160922113459

Steps to reproduce:

conversion-native-function.js expects hypot() in libc. This causes on Solaris following test error.

$ ../../dist/bin/run-mozilla.sh /builds2/psumbera/userland-ff-45.4esr/components/desktop/firefox/build/sparcv7/_virtualenv/bin/python -u /builds2/psumbera/userland-ff-45.4esr/components/desktop/firefox/firefox-45.4.0esr/js/src/jit-test/jit_test.py ../../dist/bin/js ctypes/conversion-native-function.js
/builds2/psumbera/userland-ff-45.4esr/components/desktop/firefox/firefox-45.4.0esr/js/src/jit-test/tests/ctypes/conversion-native-function.js:15:14 Error: couldn't find function symbol in library
Stack:
  test@/builds2/psumbera/userland-ff-45.4esr/components/desktop/firefox/firefox-45.4.0esr/js/src/jit-test/tests/ctypes/conversion-native-function.js:15:14
  @/builds2/psumbera/userland-ff-45.4esr/components/desktop/firefox/firefox-45.4.0esr/js/src/jit-test/tests/ctypes/conversion-native-function.js:37:3
Exit code: 3
FAIL - ctypes/conversion-native-function.js
[0|1|0|0] 100% ==========================================================>|   0.2s
FAILURES:
    /builds2/psumbera/userland-ff-45.4esr/components/desktop/firefox/firefox-45.4.0esr/js/src/jit-test/tests/ctypes/conversion-native-function.js
TIMEOUTS:


----

Note that also Linux and BSD have hypot function in libm. Though I'm not sure why this was not an issue for Linux so far.

Comment 1

[Petr Sumbera]

Attachment: Bug1309157.patch

Possible patch. Should be verified on linux.

Comment 2

[Tooru Fujisawa [:arai]]

Thank you for your patch :D

Indeed, the fix works on OSX.
will check on linux shortly.

Comment 3

[Tooru Fujisawa [:arai]]

confirmed the patch works on debian.

Comment 4

[Tooru Fujisawa [:arai]]

Triggered try run to see it also works on automated tests.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=85ed957f2984

Comment 5

[Tooru Fujisawa [:arai]]

it passed the tests ("Jit" in OS X 10.6 are pre-existing, ignore them)

Comment 6

[Tooru Fujisawa [:arai]]

Comment on attachment 8799672 [details] [diff] [review]
Bug1309157.patch

Review of attachment 8799672 [details] [diff] [review]:
-----------------------------------------------------------------

The fix is perfect :)

can you change the commit message to explain the change, instead of the issue?
then, post updated patch and set "review" flag to "?" and ask review from module owner/peer.

Comment 7

[Petr Sumbera]

Attachment: Bug1309157.patch

Can I have please review for my change? Sorry I'm not sure how should good commit message look like.

Comment 8

[Tooru Fujisawa [:arai]]

Here's documentation.
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment

So, in this case, the commit message should say something like
  Bug 1309157 - Looks for hypot in libm instead of libc in conversion-native-function.js
in single line.

Comment 9

[Tooru Fujisawa [:arai]]

Comment on attachment 8799736 [details] [diff] [review]
Bug1309157.patch

Review of attachment 8799736 [details] [diff] [review]:
-----------------------------------------------------------------

sorry I wasn't clear.
can you please change the commit message (see comment #8)?

Comment 10

[Petr Sumbera]

Attachment: Bug1309157.patch

Thank you! Do I need to change also bug synopsis here?

Comment 11

[Tooru Fujisawa [:arai]]

Comment on attachment 8799751 [details] [diff] [review]
Bug1309157.patch

Review of attachment 8799751 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you again :D

(In reply to Petr Sumbera from comment #10)
> Do I need to change also bug synopsis here?

no, bug summary should explain the issue, and commit message should explain the fix.
so, this is correct :)

forwarding to bholley, as I'm not module owner/peer here.

Comment 12

[Tooru Fujisawa [:arai]]

Comment on attachment 8799751 [details] [diff] [review]
Bug1309157.patch

Review of attachment 8799751 [details] [diff] [review]:
-----------------------------------------------------------------

just got a green light from module owner,
adding r+ and clearing additional r?

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fd0ce9fbf2b
Looks for hypot in libm instead of libc in conversion-native-function.js. r=arai

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9fd0ce9fbf2b