Closed
Bug 1309168
Opened 6 years ago
Closed 6 years ago
Fix twisty direction of ruleview-header in RTL locales
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox51 fixed, firefox52 verified)
VERIFIED
FIXED
Firefox 52
People
(Reporter: magicp.jp, Assigned: Towkir, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(2 files)
10.13 KB,
image/png
|
Details | |
605 bytes,
patch
|
ntim
:
review+
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20161010030204 Steps to reproduce: 1. Start Nightly in RTL locales (e.g. Arabic or using Force RTL) 2. Go to "about:home" 3. Right clicking on "mozilla" logo in the top-right 4. Select "Inspect Element" in the context menus Actual results: ruleview-header twisty direction is wrong. Regression range: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=73a6a267a50a0e1c41e689b265ad3eebe43d7ac6&tochange=a6b6a93eb41a05e310a11f0172f01ba9b21d3eac Expected results: Fix twisty direction of ruleview-header in RTL locales
You can reproduce this in 49 and 50. But it is a different bug.
Blocks: 1296648
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox51:
--- → affected
status-firefox52:
--- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Comment 2•6 years ago
|
||
Towkir, are you interested in taking this bug? To fix this bug, you need to change: .ruleview-expander.theme-twisty:dir(rtl) { to .ruleview-rule .ruleview-expander.theme-twisty:dir(rtl) { at https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/rules.css#331
Flags: needinfo?(3ugzilla)
Updated•6 years ago
|
Mentor: ntim.bugs
Keywords: good-first-bug
Assignee | ||
Comment 3•6 years ago
|
||
Thanks Tim, Will submit a patch soon.
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Flags: needinfo?(3ugzilla)
Comment 5•6 years ago
|
||
Comment on attachment 8800878 [details] [diff] [review] twisty_direction.patch Review of attachment 8800878 [details] [diff] [review]: ----------------------------------------------------------------- Looks great, thanks! Fixes the issue locally and doesn't seem to break anything else, r+ :)
Attachment #8800878 -
Flags: review?(ntim.bugs) → review+
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2d7194c2813e Fixed twisty direction of ruleview-header in RTL locales; r=ntim
Keywords: checkin-needed
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2d7194c2813e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment 8•6 years ago
|
||
Comment on attachment 8800878 [details] [diff] [review] twisty_direction.patch Approval Request Comment [Feature/regressing bug #]: bug 1296648 [User impact if declined]: Wrong arrow direction in RTL (see screenshot) [Describe test coverage new/current, TreeHerder]: on Nightly, local testing done [Risks and why]: low, 1 line css change [String/UUID change made/needed: no
Attachment #8800878 -
Flags: approval-mozilla-aurora?
Comment 9•6 years ago
|
||
Comment on attachment 8800878 [details] [diff] [review] twisty_direction.patch Fix a regression related to RTL. Take it in 51 aurora.
Attachment #8800878 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•6 years ago
|
||
has problems to apply to aurora: merging devtools/client/themes/rules.css warning: conflicts while merging devtools/client/themes/rules.css! (edit, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue (use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(3ugzilla)
Updated•6 years ago
|
Flags: needinfo?(3ugzilla) → needinfo?(ntim.bugs)
Comment 11•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/da6ac49228bec5e6994eafabbeae542cd59f2c97
Flags: needinfo?(ntim.bugs)
Comment 12•6 years ago
|
||
I have reproduced the bug in Nightly 52.0a1 (2016-10-11) with the instruction from comment 0 and Linux 32 Bit Bug is fixed now on Latest Nightly 53.0a1 (Build ID:20161114043454) User Agent:Mozilla/5.0 (X11; Linux i686; rv:53.0) Gecko/20100101 Firefox/53.0 & fixed Latest Developer Edition 52.0a2 (Build ID:20161114043455) User Agent:Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Firefox/52.0 [bugday-20161116]
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•