1309168 - Fix twisty direction of ruleview-header in RTL locales

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[magicp]

Attachment: fix-ruleview-header-twisty-direction-in-rtl.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161010030204

Steps to reproduce:

1. Start Nightly in RTL locales (e.g. Arabic or using Force RTL)
2. Go to "about:home"
3. Right clicking on "mozilla" logo in the top-right
4. Select "Inspect Element" in the context menus



Actual results:

ruleview-header twisty direction is wrong.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=73a6a267a50a0e1c41e689b265ad3eebe43d7ac6&tochange=a6b6a93eb41a05e310a11f0172f01ba9b21d3eac


Expected results:

Fix twisty direction of ruleview-header in RTL locales

Comment 1

[magicp]

You can reproduce this in 49 and 50. But it is a different bug.

Comment 2

[Tim Nguyen :ntim (please use needinfo?)]

Towkir, are you interested in taking this bug?

To fix this bug, you need to change:

.ruleview-expander.theme-twisty:dir(rtl) {
to
.ruleview-rule .ruleview-expander.theme-twisty:dir(rtl) {

at https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/rules.css#331

Comment 3

[[:Towkir] Ahmed]

Thanks Tim, 
Will submit a patch soon.

Comment 4

[[:Towkir] Ahmed]

Attachment: twisty_direction.patch

Hope this helps :)

Comment 5

[Tim Nguyen :ntim (please use needinfo?)]

Comment on attachment 8800878 [details] [diff] [review]
twisty_direction.patch

Review of attachment 8800878 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks! 
Fixes the issue locally and doesn't seem to break anything else, r+ :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d7194c2813e
Fixed twisty direction of ruleview-header in RTL locales; r=ntim

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2d7194c2813e

Comment 8

[Tim Nguyen :ntim (please use needinfo?)]

Comment on attachment 8800878 [details] [diff] [review]
twisty_direction.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1296648
[User impact if declined]: Wrong arrow direction in RTL (see screenshot)
[Describe test coverage new/current, TreeHerder]: on Nightly, local testing done
[Risks and why]: low, 1 line css change
[String/UUID change made/needed: no

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8800878 [details] [diff] [review]
twisty_direction.patch

Fix a regression  related to RTL. Take it in 51 aurora.

Comment 10

[Carsten Book [:Tomcat]]

has problems to apply to aurora:

merging devtools/client/themes/rules.css
warning: conflicts while merging devtools/client/themes/rules.css! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 11

[Tim Nguyen :ntim (please use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/da6ac49228bec5e6994eafabbeae542cd59f2c97

Comment 12

[Forhad Hossain]

I have reproduced the bug in Nightly 52.0a1 (2016-10-11) with the instruction from comment 0 and Linux 32 Bit

Bug is fixed now on Latest Nightly 53.0a1 (Build ID:20161114043454)
User Agent:Mozilla/5.0 (X11; Linux i686; rv:53.0) Gecko/20100101 Firefox/53.0

& fixed Latest Developer Edition 52.0a2 (Build ID:20161114043455)
User Agent:Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Firefox/52.0

[bugday-20161116]