bug909997.js test failure on sparc due set JS_CODEGEN_NONE

RESOLVED FIXED in Firefox 52

Status

()

defect
P5
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: petr.sumbera, Assigned: petr.sumbera)

Tracking

49 Branch
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160922113459

Steps to reproduce:

This is the only js test failing:

FAIL - ion/bug909997.js
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/ion/bug909997.js | /builds2/psumbera/userland-ff-45.4esr/components/desktop/firefox/firefox-45.4.0esr/js/src/jit-test/tests/ion/bug909997.js:31:5 Error: Assertion failed: got 0, expected 1 (code 3, args "")

This is becuase sparc code generation is missing (JS_CODEGEN_NONE=1) and JS_GetGlobalJitCompilerOption() will always return 0:

JS_GetGlobalJitCompilerOption(JSRuntime* rt, JSJitCompilerOption opt)
{
printf("JS_GetGlobalJitCompilerOption\n");
#ifndef JS_CODEGEN_NONE
..
#endif
    return 0;
}
  



Expected results:

Since I'm new here I would like to ask for some comments on this.

What are the consequences for FF on sparc than?
Is it expected that bug909997.js test will fail or it's another bug beside missing sparc support for code generation?
Any adivce/pointers if I decide to try to add missing sparc support?
sounds like, we need to make it possible to detect JS_CODEGEN_NONE by testing function,
and skip the test on JS_CODEGEN_NONE.

nbp, how do you think?
Component: Untriaged → JavaScript Engine: JIT
Flags: needinfo?(nicolas.b.pierron)
Product: Firefox → Core
(In reply to Petr Sumbera from comment #0)
> What are the consequences for FF on sparc than?

There is none.  This function handles reading the flags used by the JIT, but when the JIT is disabled this function does nothing.

> Any adivce/pointers if I decide to try to add missing sparc support?

Either add a new testing function [1], or a new enumerated value which is always supposed to return 1, in the JS_GetGlobalJitCompilerOption function.  Thus, in the test case, add a condition, and call the skip() function if the jit is disabled.


[1] http://searchfox.org/mozilla-central/source/js/src/builtin/TestingFunctions.cpp#3847-3851
Flags: needinfo?(nicolas.b.pierron)
Assignee

Comment 3

3 years ago
Attachment #8799890 - Flags: review?(nicolas.b.pierron)
Assignee: nobody → petr.sumbera
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8799890 [details] [diff] [review]
Bug1309246.patch

Review of attachment 8799890 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8799890 - Flags: review?(nicolas.b.pierron) → review+
The current patch just modifies the test case to skip it if Baseline is disabled (or all jit are disabled).
I think we can safely land this without any try-server run.
Keywords: checkin-needed
Priority: -- → P1
Priority: P1 → P5

Comment 6

3 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5758ad60c4d8
avoids bug909997.js test failure on systems with JS_CODEGEN_NONE set. r=nbp
Keywords: checkin-needed

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5758ad60c4d8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.