Closed
Bug 1309278
Opened 9 years ago
Closed 9 years ago
Cache::Memcached::Fast returns tainted data if the key is tainted
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 6.0
People
(Reporter: dylan, Assigned: dylan)
Details
Attachments
(3 files)
|
421 bytes,
text/troff
|
Details | |
|
698 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
|
1.99 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
So if a key is passed to Cache::Memcached::Fast->get(), and it is tainted,
for some reason the value is also tainted.
|
Assignee | |
Updated•9 years ago
|
Assignee: general → dylan
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8799852 -
Flags: review?(dkl)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8799852 [details] [diff] [review]
1309278_1.patch
Review of attachment 8799852 [details] [diff] [review]:
-----------------------------------------------------------------
Should we again remove the detainting routines that were put back with this new patch?
r=dkl
Attachment #8799852 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Yep. Here is the patch for bmo
Attachment #8799958 -
Flags: review?(dkl)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8799958 [details] [diff] [review]
1309229_bmo.patch
Review of attachment 8799958 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8799958 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
To github.com:bugzilla/bugzilla.git
d328d40..d9ba51c master -> master
To github.com:mozilla-bteam/bmo.git
b4b59f8..b955c8d master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Target Milestone: --- → Bugzilla 6.0
You need to log in
before you can comment on or make changes to this bug.
Description
•