1309278 - Cache::Memcached::Fast returns tainted data if the key is tainted

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

Attachment: test.t

So if a key is passed to Cache::Memcached::Fast->get(), and it is tainted,
for some reason the value is also tainted.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1309278_1.patch

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8799852 [details] [diff] [review]
1309278_1.patch

Review of attachment 8799852 [details] [diff] [review]:
-----------------------------------------------------------------

Should we again remove the detainting routines that were put back with this new patch?

r=dkl

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1309229_bmo.patch

Yep. Here is the patch for bmo

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8799958 [details] [diff] [review]
1309229_bmo.patch

Review of attachment 8799958 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 5

[Dylan Hardison [:dylan] (he/him)]

To github.com:bugzilla/bugzilla.git
   d328d40..d9ba51c  master -> master

To github.com:mozilla-bteam/bmo.git
   b4b59f8..b955c8d  master -> master