Closed Bug 1309296 Opened 3 years ago Closed 3 years ago

Get rid of uses of .contains() on a dataTransfer's .types in suite/ (port bug 1298243)

Categories

(SeaMonkey :: General, defect)

defect
Not set

Tracking

(seamonkey2.49esr fixed)

RESOLVED FIXED
seamonkey2.49
Tracking Status
seamonkey2.49esr --- fixed

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file)

No description provided.
Attached patch 1309296.1.diffSplinter Review
Looks like there's only 2 files that needs an update...
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #8799882 - Flags: review?(philip.chee)
Comment on attachment 8799882 [details] [diff] [review]
1309296.1.diff

frg, want to look at this? An a+ would be nice too :-)
Attachment #8799882 - Flags: review?(philip.chee) → review?(frgrahl)
Note to self: change the commit message.
Comment on attachment 8799882 [details] [diff] [review]
1309296.1.diff

Thanks. Looks good. Didn't found more in suite. im is also affected. 

r/a=me if Ratty doesn't object. Not sure if I am allowed to do this :)
Attachment #8799882 - Flags: review?(frgrahl) → review+
Depends on: 1298243
Sebastian also ported this but didn't set review yet See Bug 1309301.
See Also: → 1309301
(In reply to Frank-Rainer Grahl from comment #4)
> r/a=me if Ratty doesn't object. Not sure if I am allowed to do this :)

He doesn't, I asked him :-)

https://hg.mozilla.org/comm-central/rev/ee73c694f5ff7c26473adb6d2acbcbfcb45fd6f9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.49
IanN just popped up too and I asked him also. So I am covered :)
You need to log in before you can comment on or make changes to this bug.