1309342 - Create revised Highlight cell for Activity Stream

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect, P1)

Description

[Stephan Leroux [:sleroux]]

As we're iterating on how we want to display the Highlight row, Bryan has come up with a revised design for it. Rather than replacing our existing highlight cell design, this revised design should be implemented separately to allow for A/B tests during validation phase.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: [e-mail]

See mockup for measurements and revised design for rich highlight and regular highlight rows.

Comment 2

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8800885 [details] [review]
PR

Looks good just left some comments about a few things on the PR.

Comment 4

[Bryan Munar (:bkmunar)]

https://github.com/mozilla-mobile/firefox-ios/pull/2161/commits/3098bf135f84b9f596fb9c010a178f6246f2fd28

Comment 5

[Maurya Talisetti]

Attachment: Simulator Screen Shot 03-Nov-2016, 7.37.45 PM.png

Long titles are making the cell heights seem unequal. For example, if the title is 3 lines long, the cell height is expanding to accommodate that. If the title is just a line long, the cell height remains as intended.

In the sample screenshot, you'll see that the first 2 highlight rows have a bigger height compared to the rest of the rows in the highlights table.

I'm assuming that this is ok given the idea is to add more context to these highlight rows. Nevertheless, I just wanted to point it out so that you might consider it if necessary.