1309426 - MathML reftests failing on Ubuntu 16.04 due to different fonts

Status: RESOLVED FIXED

(Core :: MathML, defect, P5)

Description

[Karl Tomlinson (:karlt)]

dir-3.html
mo-glyph-size.html
rowlines-3-2-ref.html and
in https://treeherder.mozilla.org/logviewer.html#?job_id=28924854&repo=try
are failing due to taller font metrics.
Triggered by changes for bug 1309086

These also are failing due to different sizing of math hidden by sized boxes:
menclose-2-actuarial.html
menclose-2-box.html
menclose-2-left.html
menclose-2-roundedbox.html
menclose-2-top.html
menclose-2-updiagonalarrow.html
menclose-2-roundedbox.html

Comment 1

[Karl Tomlinson (:karlt)]

Using a more recent m-c gives a slightly different list of menclose tests,
which seems consistent across different runs.

https://treeherder.mozilla.org/logviewer.html#?job_id=29004271&repo=try

menclose-2-actuarial.html
menclose-2-bottom.html
menclose-2-box.html
menclose-2-right.html
menclose-2-roundedbox.html
menclose-2-updiagonalarrow.html
menclose-2-roundedbox.html

Comment 2

[Julien Cristau [:jcristau]]

Too late for firefox 52, mass-wontfix.

Comment 3

[Frédéric Wang (:fredw)]

In bug 1846674, I tweaked a bit the menclose-2 tests so that they always use "font: 25px/1 Ahem;" for the math/svg/#box and tried to make them more consistent using a .5em stroke width for the "covering drawing". That does not work for longdiv since the stretchy parenthesis can still use a different system-dependent font ; ideally we would provide a Web font but for now using a 1em stroke-width seems enough to work with STIX Two/Latin Modern/Cambria Math. Incidentally, I also improved menclose-2-updiagonalarrow.html (hiding the arrow head with a square) and menclose-2-roundedbox (was missing box-sizing: border-box). I removed the random-if(gtkWidget) and fuzzy annotations for menclose-2* tests.

In bug 1846945, I'm also forcing "font: 25px/1 Ahem;" for rowlines-3-2.html and similar tests (rowlines-3-1.html, columnlines-3-2.html, columnlines-3-1.html) although it's not clear to me what the issue was and Karl's treeherder results are no longer available.

Comment 4

[Frédéric Wang (:fredw)]

In https://phabricator.services.mozilla.com/D199702 I'm also trying to force 25px/1 Ahem for dir-3.html although that might not really help if Gecko choose system math fonts to calculate metrics. From comment 0, I understand the problem is with "taller font metrics" so I'm also using a taller covering rectangle.

Comment 5

[Frédéric Wang (:fredw)]

(In reply to Frédéric Wang (:fredw) from comment #4)

In https://phabricator.services.mozilla.com/D199702 I'm also trying to force 25px/1 Ahem for dir-3.html although that might not really help if Gecko choose system math fonts to calculate metrics. From comment 0, I understand the problem is with "taller font metrics" so I'm also using a taller covering rectangle.

Now only mo-glyph-size.html remains. This was introduced by bug 1219068 and skimming over the comments, it was due to some glyph selection in the stretchy code. Karl mentioned it was broken again after bug 1309086 and from the comment I suspect this relates to bug 1208776, especially large font height with latin modern math. This was supposed to be fixed in Ubuntu 16.04 ( https://bugs.launchpad.net/ubuntu/+source/lmodern/+bug/1502701 ) ; but it's not clear to me whether or not that fix was integrated yet when the change from bug 1309086 was done.

Anyway, let's try and remove the annotation and see if the bots are happy.

Comment 6

[Frédéric Wang (:fredw)]

Attachment: Bug 1309426 - Remove `random-if(gtkWidget)` for mo-glph-size.html. r=emilio

This test verifies stretchy fences don't get excessively tall. The font
used depends on what is available on the system so it may well fail
if old fonts with bad metrics are used (see 1208776 and its duplicates).
Tentatively remove the annotation, assuming our CI Linux bots no longer
use such fonts.

Comment 7

[Frédéric Wang (:fredw)]

Attachment: Bug 1309426 - Remove random-if annotation for mo-glyph-size.html. r=emilio

This test verifies stretchy fences with the default fonts don't get
excessive height. It may system math fonts with bad heights (see
bug 1208776 and duplicates) so that was likely why it was marked
after migrating some Linux bots to Ubuntu 16.04. Tentatively remove
this annotation, assuming newer versions no longer have this problem.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caba31bb3d12
Remove `random-if(gtkWidget)` for mo-glph-size.html. r=emilio

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/caba31bb3d12