1309500 - JSONFile should not mix nsIFile and OS.File

Status: NEW

(Toolkit :: General, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

JSONFile currently does I/O on two threads at once. There is potential for data loss. That's not good.

Comment 1

[Sumit Tiwari]

Am I correct in assuming that JSONFile should exclusively use OS.File, since we are slowly moving away from XPCOM-based stuff? Also, a quick look at the module shows that we are indeed using OS.File almost everywhere in the module barring a few places (actually I could only spot one occurrence, but I might be wrong).

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Well, in general, using `nsIFile` on the main thread is pretty much always a bad idea. The code of JSONFile was extracted from a larger module in which I understand it was necessary and it probably worked, but I believe that making this a tool for use by other modules is a bad idea.