1309564 - HTML and XUL bindings should only use html- and xul-namespaced traits

Status: RESOLVED FIXED

(L20n :: JS Library, defect)

Description

[Staś Małolepszy :stas]

When translating DOM attributes, the bindings code should only use traits which are in the xul and the html namespaces.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

It seems to be done now, can we close this bug?

Comment 2

[Staś Małolepszy :stas]

Can you point to where it's done?  I don't think it is.  I'd expect this code to check if trait.key.namespace is 'xul' or 'html', but that would require it to know which element the translations is for:

  https://github.com/l20n/l20n.js/blob/69fe01ff11422ffd9a0e68d91eaffa6fa8e4c321/src/lib/format.js#L138

Or, we could format all traits with namespaces and store the namespaces on the result object, and then only apply those matching the current element's namespace in:

  https://github.com/l20n/l20n.js/blob/69fe01ff11422ffd9a0e68d91eaffa6fa8e4c321/src/bindings/overlay.js#L66

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

ah, I confused the overlay ATTRIBUTES_ALLOWED with this.

I think it would be cleaner to select it in bindings than in lib

Comment 4

[Staś Małolepszy :stas]

Yeah, agree.  Want to give it a try?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

yeah

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pr

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 8805506 [details]
pr

https://github.com/l20n/l20n.js/pull/162#pullrequestreview-6252074

Comment 8

[Staś Małolepszy :stas]

Comment on attachment 8805506 [details]
pr

lgtm, thanks!

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

L20n.js: https://github.com/l20n/l20n.js/commit/357b37d75f22ecb3b92f73ffab530b211d3da6d5

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://hg.mozilla.org/projects/larch/rev/8f9c827a11e3400c939cce7f609bb0454d6c00bb
Bug 1309564 - HTML and XUL bindings should only use html- and xul-namespaced traits. r=stas