1309581 - 'Send Tab' list appears blank when signed into FxA with connected devices attached

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect, P1)

Description

[Stephan Leroux [:sleroux]]

Attachment: IMG_3635.PNG

Tested on latest master (cef88e9a6d5cf50a2e5b7acd8ad4b598aa11e04a)

STR:

1. Sign into FxA with connected devices on fresh copy of Firefox
2. Wait for sync to complete
3. Navigate to 'Synced Devices' tab to verify that connected devices appear
4. Navigate to webpage and tap 'Share' button
5. Tap 'Send Tab'

Expected:

Send Tab list should be populated with connected devices.

Actual:

List appears blank but still scrollable.

--- 

Note that this also occurs when attempting to 'Send Tab' from another application.

Comment 1

[Richard Newman [:rnewman]]

Are you having database woes on your device? :D

Anything in the log?

Comment 2

[Stephan Leroux [:sleroux]]

Heh I hope not. I seem to be finding all the sync issues this morning. Mostly filing bugs in case anyone else is seeing this. I'll dig into this and see whats going on.

Comment 3

[Stephan Leroux [:sleroux]]

Looks like the reason the list isn't being populated is because when calling 'getClients' [1], we're getting back an error that the account is in a .NotMarried state [2]. Two things could be causing this:

1. There was some changes made on the server which requires iOS to update how we handle the login handshaking [3]. We haven't made these changes yet. 

2. When advancing our FxA account state, we touch some of the new device registration API code that was introduced on master [4].

This also might effect missing history items if we're failing to pull down records because of our FxA state [5]

[1] https://github.com/mozilla-mobile/firefox-ios/blob/master/Extensions/SendTo/ClientPickerViewController.swift#L156
[2] https://github.com/mozilla-mobile/firefox-ios/blob/master/Account/FirefoxAccount.swift#L227
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1289480#c13
[4] https://github.com/mozilla-mobile/firefox-ios/blob/master/Account/FirefoxAccount.swift#L181
[5] https://bugzilla.mozilla.org/show_bug.cgi?id=1309571

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2222#attch-to-bugzilla

IIRC you worked on shared app groups/keychain stuff in the past. Mind checking out this fix?

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Looks good. Left a view comments on the PR.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8808219 [details]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2222#attch-to-bugzilla

I'll + it because I think it is all good to go. Just a question about a team identifier and how to test this.

Comment 7

[Stephan Leroux [:sleroux]]

Added comments to PR and removed the SQL commit that was supposed to be on another branch.

Comment 8

[Stephan Leroux [:sleroux]]

master https://github.com/mozilla-mobile/firefox-ios/commit/235b7dadbbe174c93b380c01d4445a583859dab1

Comment 9

[Stephan Leroux [:sleroux]]

v6.x fda6300

Comment 10

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2231

Comment 11

[Stephan Leroux [:sleroux]]

Comment on attachment 8809420 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2231

Oops wrong bug!