1309646 - Use sChangeHint_UpdateBackgroundPosition hint while mask position changed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[u459114]

1. Split nsDisplaySVGEffectsGeometry into nsDisplayMaskGeometry & nsDisplayFilterGeometry
2. Compute image mask geometry in nsDislayMaskGeometry. For now, we only compute SVG mask geometry in nsDisplaySVGEffectsGeometry.

Comment 1

[u459114]

3. Everything we did in nsDisplayBackgroundImage::ComputeInvalidationRegion, we need to re-implement in nsDisplayMask::ComputeInvalidationRegion

Comment 2

[u459114]

4. Leverage sChangeHint_UpdateBackgroundPosition hint in nsDisplayMask and nsStyleImageLayers::CalcDifference for mask

Comment 3

[u459114]

Attachment: Bug 1309646 - Part 1. Narrow down the condition of invalid whole boundary.

Review commit: https://reviewboard.mozilla.org/r/85550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85550/

Comment 4

[u459114]

Attachment: Bug 1309646 - Part 2. Add TODO comment in nsCSSRendering::ComputeImageLayerPositioningArea.

Review commit: https://reviewboard.mozilla.org/r/85552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85552/

Comment 5

[u459114]

Attachment: Bug 1309646 - Part 3. Use nsChangeHint_UpdateBackgroundPosition in position mask.

Review commit: https://reviewboard.mozilla.org/r/85554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85554/

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8800665 [details]
Bug 1309646 - Part 1. Narrow down the condition of invalid whole boundary.

https://reviewboard.mozilla.org/r/85550/#review84256

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8800666 [details]
Bug 1309646 - Part 2. Add TODO comment in nsCSSRendering::ComputeImageLayerPositioningArea.

https://reviewboard.mozilla.org/r/85552/#review84258

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8800667 [details]
Bug 1309646 - Part 3. Use nsChangeHint_UpdateBackgroundPosition in position mask.

https://reviewboard.mozilla.org/r/85554/#review84262

Comment 9

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f5ccb78283a

Comment 10

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2e8b7ab19eb

Comment 11

[u459114]

Comment on attachment 8800665 [details]
Bug 1309646 - Part 1. Narrow down the condition of invalid whole boundary.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85550/diff/1-2/

Comment 12

[u459114]

Comment on attachment 8800666 [details]
Bug 1309646 - Part 2. Add TODO comment in nsCSSRendering::ComputeImageLayerPositioningArea.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85552/diff/1-2/

Comment 13

[u459114]

Comment on attachment 8800667 [details]
Bug 1309646 - Part 3. Use nsChangeHint_UpdateBackgroundPosition in position mask.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85554/diff/1-2/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d4e4cdcce62
Part 1. Narrow down the condition of invalid whole boundary. r=mstange
https://hg.mozilla.org/integration/autoland/rev/ec99fd747ee9
Part 2. Add TODO comment in nsCSSRendering::ComputeImageLayerPositioningArea. r=mstange
https://hg.mozilla.org/integration/autoland/rev/1d99ebb404ef
Part 3. Use nsChangeHint_UpdateBackgroundPosition in position mask. r=mstange

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8d4e4cdcce62
https://hg.mozilla.org/mozilla-central/rev/ec99fd747ee9
https://hg.mozilla.org/mozilla-central/rev/1d99ebb404ef