Investigate removing node.rawNode() usage from client/framework/selection

RESOLVED FIXED in Firefox 52

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

Trunk
Firefox 52
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [devtools-html])

Attachments

(1 attachment)

selection.js is still using Cu.isDeadWrapper [1] which is a blocker for bundling the inspector using webpack.

The comment above this code states that it can be removed once no tool is relying on node.rawNode() anymore. I think this is the case, and node.rawNode() returns null in e10s anyway.

I would like to try to remove all the code related rawNode() from selection.js

[1] http://searchfox.org/mozilla-central/rev/cd1be634c9309c7fc99a3fde67dd44d343875f60/devtools/client/framework/selection.js#187
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Iteration: --- → 52.2 - Oct 17
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
Comment on attachment 8800381 [details]
Bug 1309650 - remove non remote friendly APIs from selection.js;

https://reviewboard.mozilla.org/r/85292/#review84038

Yes please! Thanks for cleaning this very old non-remote piece of code.
Attachment #8800381 - Flags: review?(pbrosset) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce9ca1a342bc
remove non remote friendly APIs from selection.js;r=pbro
Can the "rawNode" method be removed from the front now?
https://hg.mozilla.org/mozilla-central/rev/ce9ca1a342bc
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.