1309650 - Investigate removing node.rawNode() usage from client/framework/selection

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Julian Descottes [:jdescottes]]

selection.js is still using Cu.isDeadWrapper [1] which is a blocker for bundling the inspector using webpack.

The comment above this code states that it can be removed once no tool is relying on node.rawNode() anymore. I think this is the case, and node.rawNode() returns null in e10s anyway.

I would like to try to remove all the code related rawNode() from selection.js

[1] http://searchfox.org/mozilla-central/rev/cd1be634c9309c7fc99a3fde67dd44d343875f60/devtools/client/framework/selection.js#187

Comment 1

[Julian Descottes [:jdescottes]]

Hopeful try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a55f6d19c1a653163dac4f8c71f49945a1a7803

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1309650 - remove non remote friendly APIs from selection.js;

Review commit: https://reviewboard.mozilla.org/r/85292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85292/

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8800381 [details]
Bug 1309650 - remove non remote friendly APIs from selection.js;

https://reviewboard.mozilla.org/r/85292/#review84038

Yes please! Thanks for cleaning this very old non-remote piece of code.

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the review! Try push on more platforms: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4e5f3c7311847a41f8857bcfd1a59f9f319eb80

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce9ca1a342bc
remove non remote friendly APIs from selection.js;r=pbro

Comment 6

[Tom Tromey :tromey]

Can the "rawNode" method be removed from the front now?

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ce9ca1a342bc