1309652 - [e10s] CSS "display: none;" not working on <option> elements

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[cillosis]

Attachment: 2016-10-12 14_02_23-Edit fiddle - JSFiddle.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36

Steps to reproduce:

With a fresh install of version 49.0.1, view this JS fiddle: https://jsfiddle.net/e6q96zva/6/


Actual results:

The dropdown will show both the visible and hidden <option> elements, despite CSS being applied to completely hide it.

For a coworker, it worked just fine though in his Firefox (same version) and we determined through experimentation that me installing the "Classic Theme Restorer" Add-On (https://addons.mozilla.org/en-US/firefox/addon/classicthemerestorer/) will make the CSS parse correctly again. Disabling the add-on returned it back to the broken state.

A few oddities observed:

- When my coworker disables the add-on, his still works correctly. It appears this may be due to one or more other plugins/add-ons he has installed.

- If I use javascript (uncomment the blurb in the fiddle), it WILL work.


Expected results:

The expectation is the <option> tag will not be rendered when "display: none;" CSS is applied.

Comment 1

[Tooru Fujisawa [:arai]]

it's e10s only issue, related to bug 910022.

Comment 2

[Neil Deakin]

The computed display should be used in SelectContentHelper.jsm

Comment 3

[Neil Deakin]

Attachment: Use computed display

Comment 4

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77b45a6a8309c54549223ab570017585b2fa0283
Bug 1309652, use computed display when determining option display values, r=felipe

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/77b45a6a8309