1309654 - Refactor some autocomplete tests to be more readable and self-contained

Status: RESOLVED WORKSFORME

(Toolkit :: Form Manager, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

test_form_autocomplete.html is an example of a test that was written before we had nice async tooling like add_task and yield, and what we've got in there is this giant switch statement with a test counter, and (at least to my eyes) it's a little hard to reason about, and it's easy for tests to influence one another.

I think it'd be better if the tests were refactored such that they're more isolated from one another so that it's easier to introduce new tests. I also think that we should use the add_task / yield / Promises mechanisms that we've introduced over the years, since I suspect this will greatly improve readability.

This work was originally done in bug 1296638, but has been split out for reviewer sanity and also to make sure that if we introduce any intermittent oranges, we can have a greater certainty of where they were introduced (either in bug 1296638 or in here during the refactor).

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1309654 - Refactor some autocomplete tests to be more modern and readable.

Review commit: https://reviewboard.mozilla.org/r/86158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86158/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I rebased the patch onto the latest work in bug 1296638, but this still needs to be split up into more digestible chunks.

Comment 4

[Sergey Galich [:serg]]

This test has been refactored recently.