Closed Bug 1309668 Opened 3 years ago Closed 3 years ago

Change app update mar download throttling on release to 0

Categories

(Firefox :: Preferences, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox49 --- wontfix
firefox-esr45 --- wontfix
firefox50 + fixed
firefox51 + fixed
firefox52 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file, 1 obsolete file)

At the last all hands we decided that we should turn off download throttling if we can easily turn it back on if problems arise. This allows the mar to download faster.

The patch in bug 1309125 makes it so mar download throttling can be controlled by the update.xml.

The analysis in bug 1284915 comment #55 shows that the longer it takes to download the more likely it is that Firefox will experience an error during the download and thereby retry the download.
Summary: Change throttling on release to 0 → Change app update mar download throttling on release to 0
Note: it is already set to 0 on nightly and aurora.
Attachment #8800365 - Flags: review?(felipc) → review+
Attached patch patchSplinter Review
Only difference is I updated the comment to be the same as nightly and aurora... carrying over r+
Attachment #8800365 - Attachment is obsolete: true
Attachment #8800377 - Flags: review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8947f99242ae
Change app update mar download throttling on release to 0. r=felipc
[Tracking Requested - why for this release]:
One of the issues found in bug 1284915 which affects update orphaning is that throttling the mar download allows the client more time to experience an error that causes the download to start from the beginning. This bug which is a simple pref change along with bug 1309125 will make it so we don't throttle the mar download by default and if there are problems the throttle can be put back in place via the update update xml file served to clients.
https://hg.mozilla.org/mozilla-central/rev/8947f99242ae
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Tracking for 51, would be nice to have.  Ritu will make the call for 50.  Robert, can you make the uplift request for 51?
Flags: needinfo?(robert.strong.bugs)
Comment on attachment 8800377 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Part of the future mitigation strategy for bug 1284915 coment #55
[User impact if declined]: Slower updates
[Describe test coverage new/current, TreeHerder]: The current tests use this value and we've been using this value on Nightly and Aurora for several cycles.
[Risks and why]: Minimal since bug 1309125 makes it so this setting can be configured for an update via balrog
[String/UUID change made/needed]: None
Flags: needinfo?(robert.strong.bugs)
Attachment #8800377 - Flags: approval-mozilla-aurora?
Hi Rob, could you please request uplift to Beta50? Since this is a pref change and a good fix to ship soon, I am wondering if taking it in 50 makes sense. Worse case we might undo the pref if needed.
Flags: needinfo?(robert.strong.bugs)
Ritu, I only want this along with the mitigation in case there are any problems with the pref change which is bug 1309125. I'll put in requests for both.
Flags: needinfo?(robert.strong.bugs)
Comment on attachment 8800377 [details] [diff] [review]
patch

Note: for this patch to land we want the patch in bug 1309125 to also lnd to mitigate any problems in the unlikely event that they occur with the CDN.

Approval Request Comment
[Feature/regressing bug #]: Part of the future mitigation strategy for bug 1284915 coment #55
[User impact if declined]: Slower updates
[Describe test coverage new/current, TreeHerder]: The current tests use this value and we've been using this value on Nightly and Aurora for several cycles.
[Risks and why]: Minimal since bug 1309125 makes it so this setting can be configured for an update via balrog
[String/UUID change made/needed]: None
Attachment #8800377 - Flags: approval-mozilla-beta?
Comment on attachment 8800377 [details] [diff] [review]
patch

This is needed to prevent update orphaning, Aurora51+, Beta50+
Attachment #8800377 - Flags: approval-mozilla-beta?
Attachment #8800377 - Flags: approval-mozilla-beta+
Attachment #8800377 - Flags: approval-mozilla-aurora?
Attachment #8800377 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.