1309692 - Unique page title is missing on the refreshed Foundation pages

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Kohei Yoshino]

+++ This bug was initially created as a clone of Bug #1307107 +++

I guess this is a regression from Bug 1307107. The <h1> on the all(?) pages under /foundation/ is now "The Mozilla Foundation" so it's difficult to recognize each page's topic.

For example,
https://www.mozilla.org/en-US/foundation/licensing/binary-components/
The <h1> should be Mozilla Licensing Policies

https://www.mozilla.org/en-US/foundation/documents/
The <h1> should be Mozilla Foundation Documents

and so on.

Comment 1

[Kohei Yoshino]

(In reply to Kohei Yoshino [:kohei] from comment #0)
> https://www.mozilla.org/en-US/foundation/licensing/binary-components/
> The <h1> should be Mozilla Licensing Policies

In this case, actually <h2> is missing. <h1> could be "Mozilla Licensing Policies - Binary Components"

Comment 2

[Kohei Yoshino]

Attachment: pull request

Comment 3

[Alan Mooiman]

I think the appropriate solution here is to add `<h2>` elements to pages where they're missing. Doing that will

* keep the cascade of headings in the appropriate order across the pages
* remain consistent with the stakeholder and designer vision
* not create very thick red bars across the top of the pages

I also feel like the shortened `<title>` elements are fine; as they get longer they'll just get truncated in many places anyway.

Comment 4

[Eric Renaud [:erenaud]]

Bobby - thinking your input is appropriate here?

Comment 5

[Bobby Richter [:secretrobotron]]

Yeah, I think that's wise. Let me summon Sabrina to make sure.

Comment 6

[Sabrina Ng [:sabrina]]

For the design refresh, the main page along with three additional "foundation program" subpages were the focus so those designs are complete (includes h1 and h2). Now seeing how other old pages are applying the new style too, it doesn’t have the corresponding heading taken into consideration to describe the page so Kohei and Alan’s have good suggestions to include it back so it isn't just "The Mozilla Foundation" that describes the page on top.

Comment 7

[Craig Cook (:craigcook)]

Friendly ping. Any further discussion needed here? I think we've reached consensus that we should add second-level headings to each page.

Comment 8

[Bobby Richter [:secretrobotron]]

Sounds good to me. Thanks for following up on gh.

Comment 9

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/47f23f0ab3fc8a838cd14cb41d7c79417fd1c452
[fix bug 1309692] Unique page title is missing on the refreshed Foundation pages

https://github.com/mozilla/bedrock/commit/668f6e95a88d804980c1bc01f441282a410cc364
Unify foundation page titles and headings

[fix bug 1309692]

https://github.com/mozilla/bedrock/commit/3f6bdeb78f97776291f6db13eca5c4001696f6e6
Merge pull request #4576 from alanmoo/alanmoo-bug-1309692-foundation-page-titles

[fix bug 1309692] Clean up and foundation page titles and headers