Closed Bug 1309733 Opened 8 years ago Closed 8 years ago

Cleanup inspector.xhtml to load it properly in a content tab

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Iteration:
52.2 - Oct 17
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

Bug 1309733 - fix syntax issues in inspector.xhtml;
58 bytes, text/x-review-board-request
ntim
: review+
Details
In Bug 1291049 I had to do some mechanical modifications to inspector.xhtml to get it load fine in a content tab. - moving xml stylesheets to link tags - remove some self closing tags We should land this as soon as possible to avoid painful rebases while working on Bug 1291049.
Blocks: devtools-html-phase2
Flags: qe-verify?
Summary: Cleanup inspector.xhtml to load it propertly in a content tab → Cleanup inspector.xhtml to load it properly in a content tab
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Iteration: --- → 52.2 - Oct 17
Priority: P2 → P1
Tim, this bug is about cleaning the inspector.xhtml file from all the formatting/syntax issues that break when trying to load in a content tab (see Bug 1291049) Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=beb634b816e442c86246ef0ba2f2d32a0235dfe3
Comment on attachment 8801067 [details] Bug 1309733 - fix syntax issues in inspector.xhtml; https://reviewboard.mozilla.org/r/85876/#review84516 It would be nice if you could rename inspector.xhtml to inspector.html as we don't need XHTML anymore. ::: devtools/client/inspector/inspector.xhtml:11 (Diff revision 1) > > <html xmlns="http://www.w3.org/1999/xhtml" dir=""> > <head> > <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> > + > + <link rel="stylesheet" type="text/css" href="chrome://global/skin/"/> nit: remove type="text/css" here and below. It's not needed.
Attachment #8801067 - Flags: review?(ntim.bugs) → review+
Comment on attachment 8801067 [details] Bug 1309733 - fix syntax issues in inspector.xhtml; https://reviewboard.mozilla.org/r/85876/#review84516 Thanks for the review Tim. Renamed to .html > nit: remove type="text/css" here and below. It's not needed. Didn't know that, thanks for the info.
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/031441773f0d rename inspector.xhtml to inspector.html and fix syntax issues;r=ntim
Backed out for failing various inspector tests, e.g. browser_rules_select-and-copy-styles.js: https://hg.mozilla.org/integration/autoland/rev/684841660958cd6d9960654cbdd335fe7718a4b3 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=031441773f0ddb4853b1d54a91c68524d1fababa Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=5081196&repo=autoland [task 2016-10-14T14:17:20.849005Z] 14:17:20 INFO - 233 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_select-and-copy-styles.js | Clipboard has the given value - [task 2016-10-14T14:17:20.849053Z] 14:17:20 INFO - 234 INFO Testing CSS property editor value copy [task 2016-10-14T14:17:20.849121Z] 14:17:20 INFO - 235 INFO Waiting for event: 'focus' on [object HTMLSpanElement]. [task 2016-10-14T14:17:20.849170Z] 14:17:20 INFO - 236 INFO Clicking on editable field to turn to edit mode [task 2016-10-14T14:17:20.849212Z] 14:17:20 INFO - 237 INFO Got event: 'focus' on [object HTMLSpanElement]. [task 2016-10-14T14:17:20.849257Z] 14:17:20 INFO - 238 INFO Editable field gained focus, returning the input field now [task 2016-10-14T14:17:20.849309Z] 14:17:20 INFO - 239 INFO Checking that copying a css property value editor returns the correct clipboard value [task 2016-10-14T14:17:20.849375Z] 14:17:20 INFO - 240 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_select-and-copy-styles.js | Copy menu item is displayed as expected - [task 2016-10-14T14:17:20.849635Z] 14:17:20 INFO - 241 INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_select-and-copy-styles.js | Timed out while polling clipboard for pasted data - [task 2016-10-14T14:17:20.849896Z] 14:17:20 INFO - Stack trace: [task 2016-10-14T14:17:20.850201Z] 14:17:20 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:wait:951 [task 2016-10-14T14:17:20.850524Z] 14:17:20 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForClipboard/wait/<:970 [task 2016-10-14T14:17:20.850823Z] 14:17:20 INFO - Got this value: TEST-UNEXPECTED-FAIL | Clipboard text does not match expected ... results (escaped for accurate comparison): [task 2016-10-14T14:17:20.851137Z] 14:17:20 INFO - 242 INFO Actual: [task 2016-10-14T14:17:20.851395Z] 14:17:20 INFO - 243 INFO Expected: 10em [task 2016-10-14T14:17:20.851646Z] 14:17:20 INFO - 244 INFO Leaving test bound
Flags: needinfo?(jdescottes)
Looks like moving from xhtml to html has some unforeseen consequences on our tests. I'll leave that for another patch.
Flags: needinfo?(jdescottes)
Try looks green, re-landing.
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5b1bfd47d15 fix syntax issues in inspector.xhtml;r=ntim
https://hg.mozilla.org/mozilla-central/rev/c5b1bfd47d15
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Flags: qe-verify? → qe-verify-
Depends on: 1331510
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: