Console doesn't display NaN or Infinity

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Developer Tools: Shared Components
P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Dolske, Assigned: nchevobbe)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Created attachment 8800466 [details]
Screenshot

When a console command's return value is NaN or Infinity, nothing is displayed. It should show "NaN" or "Infinity". (As "123" is shown in the screenshot)
Thanks for filing. This looks like it's probably an issue with the new Reps system, which are the lower level components which render the values in both the new web console and debugger.
Blocks: 1308219
Component: Developer Tools: Console → Developer Tools: Shared Components
Priority: -- → P2
(Assignee)

Updated

a year ago
Assignee: nobody → chevobbe.nicolas
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
TRY looks fine https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c92b23a7668

Comment 4

a year ago
mozreview-review
Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

https://reviewboard.mozilla.org/r/86232/#review85572

::: devtools/client/shared/components/reps/nan.js:25
(Diff revision 1)
> +  const NaNRep = React.createClass({
> +    displayName: "NaN",
> +
> +    render: function () {
> +      return (
> +        span({className: "objectBox objectBox-nan"},

I am not seeing objectBox-nan class defined. Did you want to use objectBox-number?

Honza

Comment 5

a year ago
mozreview-review
Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

https://reviewboard.mozilla.org/r/86232/#review85574

Thanks for working on this!

Just one inline comment.

Honza
Attachment #8801475 - Flags: review?(odvarko)
(Assignee)

Comment 6

a year ago
mozreview-review-reply
Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

https://reviewboard.mozilla.org/r/86232/#review85572

> I am not seeing objectBox-nan class defined. Did you want to use objectBox-number?
> 
> Honza

No I don't (and it would be confusing I guess :) ). I added it here in case we'd want to style this in a specific way, in the future, without having to modify the JS.
I can remove it if it sounds better for you, since it doesn't do anything
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

a year ago
mozreview-review
Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

https://reviewboard.mozilla.org/r/86232/#review85800

> No I don't (and it would be confusing I guess :) ). I added it here in case
> we'd want to style this in a specific way, in the future, without having to
> modify the JS.

OK, I see

> I can remove it if it sounds better for you, since it doesn't do anything

Keep it, I agree that it can be useful.

Thanks!
Honza
Attachment #8801475 - Flags: review?(odvarko) → review+
Comment hidden (mozreview-request)

Comment 11

a year ago
Pushed by chevobbe.nicolas@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/52ae05c7eea3
Add reps for NaN and Infinity. r=Honza;

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/52ae05c7eea3
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
I have reproduced this bug with Nightly 52.0a1 (2016-10-12) (64-bit)on Windows 7, 64 Bit !

This bug's fix is verified with latest Nightly

Build   ID  20161102030205

User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

[bugday-20161102]
You need to log in before you can comment on or make changes to this bug.