1309749 - Console doesn't display NaN or Infinity

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P2)

Description

[Justin Dolske [:Dolske]]

Attachment: Screenshot

When a console command's return value is NaN or Infinity, nothing is displayed. It should show "NaN" or "Infinity". (As "123" is shown in the screenshot)

Comment 1

[Lin Clark [:linclark]]

Thanks for filing. This looks like it's probably an issue with the new Reps system, which are the lower level components which render the values in both the new web console and debugger.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1309749 - Add reps for NaN and Infinity. ;

Add reps and test for it.
Edit Number rep's `supportsObject` function because there was
an error for `-0` object, due to some change in the function which
detect which rep to use.

Review commit: https://reviewboard.mozilla.org/r/86232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86232/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

TRY looks fine https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c92b23a7668

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

https://reviewboard.mozilla.org/r/86232/#review85572

::: devtools/client/shared/components/reps/nan.js:25
(Diff revision 1)
> +  const NaNRep = React.createClass({
> +    displayName: "NaN",
> +
> +    render: function () {
> +      return (
> +        span({className: "objectBox objectBox-nan"},

I am not seeing objectBox-nan class defined. Did you want to use objectBox-number?

Honza

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

https://reviewboard.mozilla.org/r/86232/#review85574

Thanks for working on this!

Just one inline comment.

Honza

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

https://reviewboard.mozilla.org/r/86232/#review85572

> I am not seeing objectBox-nan class defined. Did you want to use objectBox-number?
> 
> Honza

No I don't (and it would be confusing I guess :) ). I added it here in case we'd want to style this in a specific way, in the future, without having to modify the JS.
I can remove it if it sounds better for you, since it doesn't do anything

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86232/diff/1-2/

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86232/diff/2-3/

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

https://reviewboard.mozilla.org/r/86232/#review85800

> No I don't (and it would be confusing I guess :) ). I added it here in case
> we'd want to style this in a specific way, in the future, without having to
> modify the JS.

OK, I see

> I can remove it if it sounds better for you, since it doesn't do anything

Keep it, I agree that it can be useful.

Thanks!
Honza

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8801475 [details]
Bug 1309749 - Add reps for NaN and Infinity. ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86232/diff/3-4/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52ae05c7eea3
Add reps for NaN and Infinity. r=Honza;

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/52ae05c7eea3

Comment 13

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 52.0a1 (2016-10-12) (64-bit)on Windows 7, 64 Bit !

This bug's fix is verified with latest Nightly

Build   ID  20161102030205

User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

[bugday-20161102]