Closed Bug 1309770 Opened 8 years ago Closed 8 years ago

V4 update error "2147500037"

Categories

(Toolkit :: Safe Browsing, defect, P1)

Product:
Toolkit
Component:
Safe Browsing
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: hchang, Assigned: hchang)

References

Details

An update error is seen listmanager: 16:10:56 GMT-0700 (PDT): makeUpdateRequestForEntry_: requestPayload ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARD-lAEaAhgH_QpxSiICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABEPuXARoCGAfnEG5nIgIgAigBGicIAxACGhsKDQgDEAYYASIDMDAxMAEQ0YABGgIYBxD-jaYiAiACKAE= update: https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] tablelist: googpub-phish-proto,goog-malware-proto,goog-unwanted-proto and the states are browser.safebrowsing.provider.google4.state.goog-malware-proto;Cg0IARAGGAEiAzAwMTABEIGYARoCGAcQ6CX3 browser.safebrowsing.provider.google4.state.goog-unwanted-proto;Cg0IAxAGGAEiAzAwMTABENaAARoCGAdslWF8 browser.safebrowsing.provider.google4.state.googpub-phish-proto;Cg0IAhAGGAEiAzAwMTABEIaVARoCGAdPxub6 All files under safebrowsing/ are gone. This is all we know for now.
Priority: -- → P1
Sadly NS_ERROR_FAILURE(In reply to Henry Chang [:henry][:hchang] from comment #0) > An update error is seen > > listmanager: 16:10:56 GMT-0700 (PDT): makeUpdateRequestForEntry_: > requestPayload > ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARD- > lAEaAhgH_QpxSiICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABEPuXARoCGAfnEG5nIgIgAigBG > icIAxACGhsKDQgDEAYYASIDMDAxMAEQ0YABGgIYBxD-jaYiAiACKAE= > update: > https://safebrowsing.googleapis.com/v4/threatListUpdates: > fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] > tablelist: googpub-phish-proto,goog-malware-proto,goog-unwanted-proto > > and the states are > > browser.safebrowsing.provider.google4.state.goog-malware-proto; > Cg0IARAGGAEiAzAwMTABEIGYARoCGAcQ6CX3 > browser.safebrowsing.provider.google4.state.goog-unwanted-proto; > Cg0IAxAGGAEiAzAwMTABENaAARoCGAdslWF8 > browser.safebrowsing.provider.google4.state.googpub-phish-proto; > Cg0IAhAGGAEiAzAwMTABEIaVARoCGAdPxub6 > > All files under safebrowsing/ are gone. > > This is all we know for now. The error log should be: listmanager: 16:10:56 GMT-0700 (PDT): makeUpdateRequestForEntry_: requestPayload ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARD-lAEaAhgH_QpxSiICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABEPuXARoCGAfnEG5nIgIgAigBGicIAxACGhsKDQgDEAYYASIDMDAxMAEQ0YABGgIYBxD-jaYiAiACKAE= update: https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] tablelist: googpub-phish-proto,goog-malware-proto,goog-unwanted-proto ... listmanager: 16:10:57 GMT-0700 (PDT): update error for googpub-phish-proto,goog-malware-proto,goog-unwanted-proto from https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]: 2147500037
Sadly 2147500037 is just NS_ERROR_FAILURE :( Nothing suggestive.
This is the same updates failing with MOZ_LOG="UrlClassifierDbService:5": [URL Classifier]: D/UrlClassifierDbService Private store directory for googpub-phish-proto is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing/google4 [URL Classifier]: D/UrlClassifierDbService Private store directory for goog-malware-proto is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing/google4 [URL Classifier]: D/UrlClassifierDbService Private store directory for goog-unwanted-proto is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing/google4 [URL Classifier]: D/UrlClassifierDbService Private store directory for goog-malware-shavar is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for goog-unwanted-shavar is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for test-malware-simple is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for test-unwanted-simple is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for goog-phish-shavar is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for test-phish-simple is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for test-block-simple is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for mozplugin-block-digest256 is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for test-track-simple is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for base-track-digest256 is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for test-trackwhite-simple is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for mozstd-trackwhite-digest256 is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Private store directory for goog-badbinurl-shavar is /home/francois/.cache/mozilla/firefox/7jw3jjqg.Francois/safebrowsing [URL Classifier]: D/UrlClassifierDbService Applying 3 table updates. [URL Classifier]: D/UrlClassifierDbService Classifier::UpdateTableV4(googpub-phish-proto) [URL Classifier]: D/UrlClassifierDbService Notifying error: NS_ERROR_FAILURE (-2147467259) [URL Classifier]: D/UrlClassifierDbService Spoiling table: googpub-phish-proto listmanager: 21:57:47 GMT-0700 (PDT): update error for googpub-phish-proto,goog-malware-proto,goog-unwanted-proto from https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]: 2147500037
Here's a log with MOZ_LOG="UrlClassifierDbService:0,nsChannelClassifier:0,UrlClassifierProtocolParser:5,UrlClassifierStreamUpdater:5,UrlClassifierPrefixSet:0" listmanager: 16:33:00 GMT-0700 (PDT): Initializing update checker for https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] provided by google4 listmanager: 16:33:00 GMT-0700 (PDT): Next update at 1476326524007 listmanager: 16:33:00 GMT-0700 (PDT): Next update 0ms from now ... listmanager: 16:33:00 GMT-0700 (PDT): update request: { "tableList": "googpub-phish-proto,goog-malware-proto,goog-unwanted-proto", "tableNames": { "googpub-phish-proto": true, "goog-malware-proto": true, "goog-unwanted-proto": true }, "requestPayload": "ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARDblQEaAhgHgODyGyICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABENmYARoCGAffLMnhIgIgAigBGicIAxACGhsKDQgDEAYYASIDMDAxMAEQo4EBGgIYBwOrnDIiAiACKAE=", "isPostRequest": false } ... listmanager: 16:33:00 GMT-0700 (PDT): makeUpdateRequestForEntry_: requestPayload ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARDblQEaAhgHgODyGyICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABENmYARoCGAffLMnhIgIgAigBGicIAxACGhsKDQgDEAYYASIDMDAxMAEQo4EBGgIYBwOrnDIiAiACKAE= update: https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] tablelist: googpub-phish-proto,goog-malware-proto,goog-unwanted-proto [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater init [this=7f26c79bc620] [Main Thread]: D/UrlClassifierStreamUpdater FetchUpdate: https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] [Main Thread]: D/UrlClassifierStreamUpdater (pre) Fetching update from https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] [Main Thread]: D/UrlClassifierStreamUpdater (post) Fetching update from https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$req=ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARDblQEaAhgHgODyGyICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABENmYARoCGAffLMnhIgIgAigBGicIAxACGhsKDQgDEAYYASIDMDAxMAEQo4EBGgIYBwOrnDIiAiACKAE= [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::OnStartRequest (status=NS_OK, uri=https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$req=ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARDblQEaAhgHgODyGyICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABENmYARoCGAffLMnhIgIgAigBGicIAxACGhsKDQgDEAYYASIDMDAxMAEQo4EBGgIYBwOrnDIiAiACKAE=, this=7f26c79bc620) [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::OnStartRequest succeeded (200) [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::Beginning stream [this=7f26c79bc620] [Main Thread]: D/UrlClassifierStreamUpdater OnDataAvailable (1321 bytes) [Main Thread]: D/UrlClassifierStreamUpdater OnStopRequest (status 0, beganStream true, this=7f26c79bc620) [URL Classifier]: D/UrlClassifierProtocolParser ==== Update for threat type '2' ==== [URL Classifier]: D/UrlClassifierProtocolParser * listName: googpub-phish-proto [URL Classifier]: D/UrlClassifierProtocolParser * newState: "0010ܕ�yv- [URL Classifier]: D/UrlClassifierProtocolParser * isFullUpdate: no [URL Classifier]: D/UrlClassifierProtocolParser * Encoding info: [URL Classifier]: D/UrlClassifierProtocolParser - First value: 13782289 [URL Classifier]: D/UrlClassifierProtocolParser - Num of entries: 191 [URL Classifier]: D/UrlClassifierProtocolParser - Rice parameter: 24 [URL Classifier]: D/UrlClassifierProtocolParser * Encoding info: [URL Classifier]: D/UrlClassifierProtocolParser - First value: 33361 [URL Classifier]: D/UrlClassifierProtocolParser - Num of entries: 95 [URL Classifier]: D/UrlClassifierProtocolParser - Rice parameter: 25 [URL Classifier]: D/UrlClassifierProtocolParser [URL Classifier]: D/UrlClassifierProtocolParser ==== Update for threat type '1' ==== [URL Classifier]: D/UrlClassifierProtocolParser * listName: goog-malware-proto [URL Classifier]: D/UrlClassifierProtocolParser * newState: "0010ژM�I [URL Classifier]: D/UrlClassifierProtocolParser * isFullUpdate: no [URL Classifier]: D/UrlClassifierProtocolParser * Encoding info: [URL Classifier]: D/UrlClassifierProtocolParser - First value: 619838185 [URL Classifier]: D/UrlClassifierProtocolParser - Num of entries: 6 [URL Classifier]: D/UrlClassifierProtocolParser - Rice parameter: 28 [URL Classifier]: D/UrlClassifierProtocolParser * Encoding info: [URL Classifier]: D/UrlClassifierProtocolParser - First value: 19588 [URL Classifier]: D/UrlClassifierProtocolParser - Num of entries: 16 [URL Classifier]: D/UrlClassifierProtocolParser - Rice parameter: 28 [URL Classifier]: D/UrlClassifierProtocolParser [URL Classifier]: D/UrlClassifierProtocolParser ==== Update for threat type '3' ==== [URL Classifier]: D/UrlClassifierProtocolParser * listName: goog-unwanted-proto [URL Classifier]: D/UrlClassifierProtocolParser * newState: "0010����2 [URL Classifier]: D/UrlClassifierProtocolParser * isFullUpdate: no [URL Classifier]: D/UrlClassifierProtocolParser SafeBrowsing: 16:33:01 GMT-0700 (PDT): reading prefs ... [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::StreamFinished [0, 0] [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::Done [this=7f26c79bc620] ... [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::UpdateError [this=7f26c79bc620] [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::DownloadDone [this=7f26c79bc620] listmanager: 16:33:02 GMT-0700 (PDT): update error for googpub-phish-proto,goog-malware-proto,goog-unwanted-proto from https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]: 2147500037 It looks like we're having problems parsing the goog-unwanted-proto list?
After updating Nightly, I got a successful update: listmanager: 16:40:38 GMT-0700 (PDT): makeUpdateRequestForEntry_: requestPayload ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARDclQEaAhgHonl2LSICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABENqYARoCGAdNjUkYIgIgAigBGicIAxACGhsKDQgDEAYYASIDMDAxMAEQo4EBGgIYBwOrnDIiAiACKAE= update: https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] tablelist: googpub-phish-proto,goog-malware-proto,goog-unwanted-proto listmanager: 16:40:39 GMT-0700 (PDT): update success for googpub-phish-proto,goog-malware-proto,goog-unwanted-proto from https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]: 1000 listmanager: 16:40:39 GMT-0700 (PDT): Waiting 1000000ms listmanager: 16:40:39 GMT-0700 (PDT): Setting last update of google4 to 1476402039438 listmanager: 16:40:39 GMT-0700 (PDT): Setting next update of google4 to 1476403039438 (1000000ms from now) which changed my state to: browser.safebrowsing.provider.google4.state.goog-malware-proto;Cg0IARAGGAEiAzAwMTABENyYARoCGAdEdhBc browser.safebrowsing.provider.google4.state.goog-unwanted-proto;Cg0IAxAGGAEiAzAwMTABEKSBARoCGAc7ABiF browser.safebrowsing.provider.google4.state.googpub-phish-proto;Cg0IAhAGGAEiAzAwMTABEN2VARoCGAfhEdSk and then later I got the following failure: [Main Thread]: D/UrlClassifierStreamUpdater FetchUpdate: https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] [Main Thread]: D/UrlClassifierStreamUpdater (pre) Fetching update from https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key] [Main Thread]: D/UrlClassifierStreamUpdater (post) Fetching update from https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$req=ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARDclQEaAhgHonl2LSICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABENqYARoCGAdNjUkYIgIgAigBGicIAxACGhsKDQgDEAYYASIDMDAxMAEQo4EBGgIYBwOrnDIiAiACKAE= [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::OnStartRequest (status=NS_OK, uri=https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$req=ChUKE25hdmNsaWVudC1hdXRvLWZmb3gaJwgCEAIaGwoNCAIQBhgBIgMwMDEwARDclQEaAhgHonl2LSICIAIoARonCAEQAhobCg0IARAGGAEiAzAwMTABENqYARoCGAdNjUkYIgIgAigBGicIAxACGhsKDQgDEAYYASIDMDAxMAEQo4EBGgIYBwOrnDIiAiACKAE=, this=7fa182ce4620) [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::OnStartRequest succeeded (200) [Main Thread]: D/UrlClassifierStreamUpdater nsUrlClassifierStreamUpdater::Beginning stream [this=7fa182ce4620] [Main Thread]: D/UrlClassifierStreamUpdater OnDataAvailable (1446 bytes) [Main Thread]: D/UrlClassifierStreamUpdater OnStopRequest (status 0, beganStream true, this=7fa182ce4620) [URL Classifier]: D/UrlClassifierProtocolParser ==== Update for threat type '2' ==== [URL Classifier]: D/UrlClassifierProtocolParser * listName: googpub-phish-proto [URL Classifier]: D/UrlClassifierProtocolParser * newState: ^M^H^B^P^F^X^A"^C0010^A^PÝ<95>^A^Z^B^X^Gá^QÔ¤ [URL Classifier]: D/UrlClassifierProtocolParser * isFullUpdate: no [URL Classifier]: D/UrlClassifierProtocolParser * Encoding info: [URL Classifier]: D/UrlClassifierProtocolParser - First value: 526189 [URL which is interesting because the debug output is cut off in a different place.
I reproduced this issue, too. Just run a nightly with "-proto" prefs set. I'll locally apply patch in Bug 1310142 to collect enough data for debugging.
I am having a test with the patch in Bug 1310142 applied. What I expect is I can find something useful in "safebrowsing-updatewreck" while something is running wrong with the update. BTW, I think only the very first error is something unknown. The following errors are due to the dangling states in prefs. Fortunately, this issue will no longer occur after Bug 1305484 landed since the state/checksum (aka table's metadata) will be removed on update failure [1]. That said, the metadata file will not be removed on "prefix loading failure" [2]. Dimi, would you like to fix "the lack of metadata file removal on loading failure" issue in the patch you are working on or like me to file a separate bug to fix it? [1] https://dxr.mozilla.org/mozilla-central/rev/9079d167112122805f99f57bb8856e1b1675af0f/toolkit/components/url-classifier/Classifier.cpp#553 [2] https://dxr.mozilla.org/mozilla-central/rev/9079d167112122805f99f57bb8856e1b1675af0f/toolkit/components/url-classifier/LookupCache.cpp#93
Flags: needinfo?(dlee)
(In reply to Henry Chang [:henry][:hchang] from comment #6) > > Dimi, would you like to fix "the lack of metadata file removal on loading > failure" issue in the patch you are working on or like me to file a separate > bug to fix it? > My patch in Bug 1305780 will remove .metadata on loading failure and it is waiting for review. So if everything is ok then it will be fixed in that bug :)
Flags: needinfo?(dlee)
Assignee: nobody → hchang
From the data I collected by the patch in Bug 1310142, we hit the case [1] where "Add prefix should not exist in the original prefix set." I assumed it's google's fault so I just changed the code to ignore this warning and pick the "old prefix" to add to the output prefixes. Unfortunately, the resulting prefixes doesn't have the right checksum. (That said, it might still be google's fault: they might have sent us addition prefixes which we already have in disk along with incorrect checksum. But that's less possible ^^") So, to debug this issue, what we can do now is to land Bug 1305581 ASAP to ensure every single update is sane and ask google what we should do when receiving addition prefixes which we already have. I would guess the dup prefix is just considered illegal. [1] https://dxr.mozilla.org/mozilla-central/rev/01ab78dd98805e150b0311cce2351d5b408f3001/toolkit/components/url-classifier/LookupCacheV4.cpp#212
(In reply to Henry Chang [:henry][:hchang] from comment #9) > From the data I collected by the patch in Bug 1310142, we hit the case [1] > where > > "Add prefix should not exist in the original prefix set." Did you see debug messages to that effect in the log when you were applying the update? I don't remember seeing anything, which tells me that we should add more logging there to make it quicker to detect problems like this in the future. > So, to debug this issue, what we can do now is to land Bug 1305581 ASAP to > ensure every single update is sane and ask google what we should do > when receiving addition prefixes which we already have. I would guess the > dup prefix is just considered illegal. Agreed. It's possible we have a bad local DB (it doesn't match the state) and so we can't apply the updates that Google sends us. Should we think about resetting the local DB when we encounter errors like these? It shouldn't happen once we have the checksums in place, but things that "shouldn't happen" have a tendency to happen anyways in the real world :/
(In reply to François Marier [:francois] from comment #10) > Agreed. It's possible we have a bad local DB (it doesn't match the state) > and so we can't apply the updates that Google sends us. > > Should we think about resetting the local DB when we encounter errors like > these? It shouldn't happen once we have the checksums in place, but things > that "shouldn't happen" have a tendency to happen anyways in the real world > :/ I guess you are saying bug 1305780 ? This bug will reset both in-memory and on-disk data for that table.
(In reply to Dimi Lee[:dimi][:dlee] from comment #11) > I guess you are saying bug 1305780 ? This bug will reset both in-memory and > on-disk data for that table. You're right, that's exactly what gcp was describing in https://bugzilla.mozilla.org/show_bug.cgi?id=1305780#c3
I have verified that the local DB for goog-unwanted-proto doesn't match the checksum. I believe that's why the addition prefixes have dups. The actual update error must have happened earlier. I should apply patch in Bug 1305581 to detect the actual issue.
(In reply to François Marier [:francois] from comment #10) > (In reply to Henry Chang [:henry][:hchang] from comment #9) > > From the data I collected by the patch in Bug 1310142, we hit the case [1] > > where > > > > "Add prefix should not exist in the original prefix set." > > Did you see debug messages to that effect in the log when you were applying > the update? > > I don't remember seeing anything, which tells me that we should add more > logging there to make it quicker to detect problems like this in the future. > That's a warning message which can be only seen in debug build :(
(In reply to Henry Chang [:henry][:hchang] from comment #14) > That's a warning message which can be only seen in debug build :( And I saw that Dimi just fixed that problem in his patch for bug 1305581. \o/ I guess we can close this bug since the fixes are happening in bug 1305581 and bug 1305780.
Status: NEW → RESOLVED
Closed: 8 years ago
Depends on: 1305780, 1305581
Resolution: --- → FIXED
See Bug 1312323 for the root cause and the solution.
Depends on: 1312323
You need to log in before you can comment on or make changes to this bug.