1309810 - Firefox Hotfix displays about:newaddon page

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: screenshot

Using old Firefox logo during Hotfix installation may prevent users from installing the add-on, when the installation screen appears for them, as it looks suspicious. It would be good to be able to avoid the screen at all, but the logo is still show in the add-on manager.

Comment 1

[Marco Castelluccio [:marco]]

Why are we even showing the about:newaddon page?

Comment 2

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #1)
> Why are we even showing the about:newaddon page?

This is bug 1300523.

Comment 3

[Marco Castelluccio [:marco]]

Isn't the incompatibility dialog from bug 1300523 a different thing that shows up
in different situations than about:newaddon?

Comment 4

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #3)
> Isn't the incompatibility dialog from bug 1300523 a different thing that
> shows up
> in different situations than about:newaddon?

Oh, hm, maybe? Felipe?

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Michael, which Firefox version are you using?

Comment 6

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

This has been actually spotted by Michal Vašíček, so I am passing the NI on him. Just note we wanted initially to point out the old Firefox logo, which is being used also on AMO.

Comment 7

[Robert Strong (they/them - no direct email)]

The issue with the hotfix causing the display of about:newaddon page won't be fixed in app update and will either be fixed in the system add-on or the add-ons mgr. Moving to the add-ons mgr.

Comment 8

[Robert Helmer [:rhelmer]]

about:newaddon should only be displayed if the add-on appears to be side-loaded (addon.seen == false) and the addon is not already enabled:

https://dxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#1108

I don't see anyplace where the hotfix addon would be explicitly marked as seen, or excluded from the check - presumably it's usually enabled before the check happens. This could be a timing issue (hotfix is download to disk and moved into place, but either AddonInstall fails or the app is shut down before it can finish).

I'd be curious to know if this is related at all to session restore, and if it happens every startup or just happened the one time.

Comment 9

[:shell escalante]

we can't see how making it happen.  with more details we will look at it - but can't repro now.

Comment 10

[Michal Vašíček [:mivasi]]

I'm sorry, but I don't know in what version was the screen taken. It was school computer and I'm not able to access it anymore.