Closed
Bug 1309868
Opened 8 years ago
Closed 8 years ago
stylo: Use const pointer in C++ side for immutable borrowed reference
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(5 files)
|
58 bytes,
text/x-review-board-request
|
bholley
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
heycam
:
review+
manishearth
:
review+
|
Details |
No description provided.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8800651 [details]
Bug 1309868 part 5 - Use const pointer in C++ side for immutable borrowed reference.
https://reviewboard.mozilla.org/r/85516/#review84138
Attachment #8800651 -
Flags: review?(manishearth) → review+
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8800647 [details]
Bug 1309868 part 1 - Use const nsIContent pointer in some DOM utils.
https://reviewboard.mozilla.org/r/85508/#review84372
Nice! Thanks for fixing this stuff.
Attachment #8800647 -
Flags: review?(bobbyholley) → review+
|
||
Comment 8•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8800648 [details]
Bug 1309868 part 2 - Use const nsIContent pointer in some layout utils.
https://reviewboard.mozilla.org/r/85510/#review85372
Attachment #8800648 -
Flags: review?(cam) → review+
|
|
||
Comment 9•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8800649 [details]
Bug 1309868 part 3 - Make NonOwningStyleContextSource store const ServoComputedValues.
https://reviewboard.mozilla.org/r/85512/#review85380
Attachment #8800649 -
Flags: review?(cam) → review+
|
|
||
Comment 10•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8800650 [details]
Bug 1309868 part 4 - Use mutable reference for Gecko_GetNextStyleChild.
https://reviewboard.mozilla.org/r/85514/#review85384
Attachment #8800650 -
Flags: review?(cam) → review+
|
|
||
Comment 11•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8800651 [details]
Bug 1309868 part 5 - Use const pointer in C++ side for immutable borrowed reference.
https://reviewboard.mozilla.org/r/85516/#review85386
Attachment #8800651 -
Flags: review?(cam) → review+
|
||
Comment 12•8 years ago
|
||
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/554fc8a1c4db
part 1 - Use const nsIContent pointer in some DOM utils. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3b872c9f642
part 2 - Use const nsIContent pointer in some layout utils. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/11210065fa4a
part 3 - Make NonOwningStyleContextSource store const ServoComputedValues. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa65809aafc3
part 4 - Use mutable reference for Gecko_GetNextStyleChild. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/47b026d2f4ed
part 5 - Use const pointer in C++ side for immutable borrowed reference. r=manishearth,heycam
|
||
Comment 13•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/554fc8a1c4db
https://hg.mozilla.org/mozilla-central/rev/a3b872c9f642
https://hg.mozilla.org/mozilla-central/rev/11210065fa4a
https://hg.mozilla.org/mozilla-central/rev/fa65809aafc3
https://hg.mozilla.org/mozilla-central/rev/47b026d2f4ed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•