Report: List of Triage Owners which can be sorted and filtered on product and component

RESOLVED FIXED

Status

()

task
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: emceeaich, Assigned: dkl)

Tracking

(Blocks 1 bug)

Production
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Need a report of the triage owner, with columns for product and component. Each triage owner should link to a buglist of all open bugs, since 2016-06-01, without a pending needinfo, where the priority is '--'
Assignee

Updated

3 years ago
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Assignee

Comment 1

3 years ago
Posted patch 1309965_1.patch (obsolete) β€” β€” Splinter Review
Emma, I have also put this patch on our test instance for testing/feedback. Please give it a try.

To https://github.com/mozilla-bteam/bmo.git
   da3322b..fd3fafd  development -> development

https://bugzilla-dev.allizom.org/page.cgi?id=triage_owners.html

dkl
Flags: needinfo?(ehumphries)
Attachment #8802696 - Flags: review?(dylan)
Feedback:

1. Form seems to fail with 500 error if I don't select a component, can "All" be selected by default when selecting a product.
2. I was hoping that the report page would load with all the components in Core, Firefox, Firefox for Android, Firefox for iOS, and Toolkit so that you didn't have to filter to get a result.
3. Would it be possible to also allow filtering on the triage owner so a person can get a report of all the bugs they are responsible for?
4. The page uses POST, can it use a GET so a report can be bookmarked?
Flags: needinfo?(ehumphries) → needinfo?(dkl)
Some more things:

5. I created https://bugzilla-dev.allizom.org/show_bug.cgi?id=1154566 in Firefox: Bookmarks & History, and when I filtered on that component the buglist did not show up until I assigned a triage owner.
6. Can the link to the bug list say 'N bugs'?
7. In the select box the '&' is showing up as the HTML entity '&'
8. When I change the component in a product and click generate a report, I get a 500 error. If I click the component again and click generate, it works.
9. Typo at bottom, "Found 63 ownerss:"
Flags: needinfo?(dkl)
Assignee

Comment 4

3 years ago
(In reply to Emma Humphries β˜•οΈ [:emceeaich] (UTC-8) +needinfo me from comment #2)
> Feedback:
> 
> 1. Form seems to fail with 500 error if I don't select a component, can
> "All" be selected by default when selecting a product.

Yeah I get the 500 error sometimes as well. I think bugzilla-dev has two webheads and once is missing a 
dependency and the other has it. Reloading will get the page eventually til I fix that.

> 2. I was hoping that the report page would load with all the components in
> Core, Firefox, Firefox for Android, Firefox for iOS, and Toolkit so that you
> didn't have to filter to get a result.

So just do away with the product/component selectors and always just show all components from that list of products?

> 3. Would it be possible to also allow filtering on the triage owner so a
> person can get a report of all the bugs they are responsible for?

I can add a user filter similar to the user activity report.

> 4. The page uses POST, can it use a GET so a report can be bookmarked?

Yep

(In reply to Emma Humphries β˜•οΈ [:emceeaich] (UTC-8) +needinfo me from comment #3)
> Some more things:
> 
> 5. I created https://bugzilla-dev.allizom.org/show_bug.cgi?id=1154566 in
> Firefox: Bookmarks & History, and when I filtered on that component the
> buglist did not show up until I assigned a triage owner.

Ok will take a look.

> 6. Can the link to the bug list say 'N bugs'?

Sure. Adds a little performance hit though as I will need to run each query for each component to get the count.

> 7. In the select box the '&' is showing up as the HTML entity '&'

Will fix.

> 8. When I change the component in a product and click generate a report, I
> get a 500 error. If I click the component again and click generate, it works.

part of the two web heads being out of sync issue.

> 9. Typo at bottom, "Found 63 ownerss:"

Will change to Found XX components.
Assignee

Comment 5

3 years ago
Comment on attachment 8802696 [details] [diff] [review]
1309965_1.patch

Removing r? as this is going through some changes.
Attachment #8802696 - Flags: review?(dylan)
Assignee

Comment 6

3 years ago
Posted patch 1309965_2.patch β€” β€” Splinter Review
New patch should address most of the suggested changes. Please try it out.

To https://github.com/mozilla-bteam/bmo.git
   e48a638..dce5439  development -> development

https://bugzilla-dev.allizom.org/page.cgi?id=triage_owners.html

dkl
Attachment #8802696 - Attachment is obsolete: true
Attachment #8803411 - Flags: review?(dylan)
:dkl I looked at the new patch, it looks good. 

The one other change I'd want to have is that for the components without owners, I still want a link to a list of all untriaged bugs.
Assignee

Comment 8

3 years ago
(In reply to Emma Humphries β˜•οΈ [:emceeaich] (UTC-8) +needinfo me from comment #7)
> :dkl I looked at the new patch, it looks good. 
> 
> The one other change I'd want to have is that for the components without
> owners, I still want a link to a list of all untriaged bugs.

Ah good idea. Sorry missed that before. Should be easy to add.

dkl
Assignee

Comment 9

3 years ago
(In reply to David Lawrence [:dkl] from comment #8)
> Ah good idea. Sorry missed that before. Should be easy to add.
> 
> dkl

Should be on bugzilla-dev soon.

dkl
Comment on attachment 8803411 [details] [diff] [review]
1309965_2.patch

r=dylan
Attachment #8803411 - Flags: review?(dylan) → review+
Assignee

Comment 11

3 years ago
(In reply to Dylan Hardison [:dylan] from comment #10)
> Comment on attachment 8803411 [details] [diff] [review]
> 1309965_2.patch
> 
> r=dylan

Emma, is this ready to go you think?

dkl
Flags: needinfo?(ehumphries)
Assignee

Comment 13

3 years ago
To https://github.com/mozilla-bteam/bmo.git
   f2fb476..ad6aa9f  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Assignee

Comment 14

3 years ago
This report should be live now.

dkl
You need to log in before you can comment on or make changes to this bug.