1310015 - [css-flexbox][css-align] MainAxisTracker inappropriately compares mJustifyContent against NS_STYLE_ALIGN constants

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Brad Werth [:bradwerth]]

The constructor for MainAxisTracker uses NS_STYLE_ALIGN constants in one section, when it should use NS_STYLE_JUSTIFY constants throughout. The constants are equivalent at the moment, but the use is semantically wrong and should be fixed.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1310015: Change MainAxisTracker to consistently use NS_STYLE_JUSTIFY constants.

Review commit: https://reviewboard.mozilla.org/r/85688/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85688/

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 8800863 [details]
Bug 1310015: Change MainAxisTracker to consistently use NS_STYLE_JUSTIFY constants.

https://reviewboard.mozilla.org/r/85688/#review84370

(Stealing the review since dholbert is on PTO.)

Yes, for readability it's better to compare 'justify' values to NS_STYLE_JUSTIFY_ constants,
even though they are always the same as NS_STYLE_ALIGN_ constants.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ccac82a6bcf
Change MainAxisTracker to consistently use NS_STYLE_JUSTIFY constants. r=mats

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ccac82a6bcf

Comment 5

[Daniel Holbert [:dholbert]]

[Looks like this still has "r?dholbert" in mozreview, and hence is still in my review queue. Updating "dholbert" to "mats" as the mozreview reviewer.]