1310063 - verify dependencies between multiple Rust libraries

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

See bug 1304815 comment 31, and this code which would be nice to put back into the recursive make backend in some form:

        # XXX We want something like this check because we thought that the
        # following dependency structure would work:
        #
        # libxul.so depends on gkrust
        # libxul-gtest.so depends on libxul_s.a depends on gkrust
        #                 depends on gkrust-gtest depends on gkrust
        #
        # But it does not, because for libxul.so's purposes, we need to
        # declare gkrust as a staticlib, but cargo then doesn't properly
        # link it in when compiling gkrust-gtest.  So we instead declare
        # a gkrust-shared and have both gkrust and gkrust-gtest depend
        # on that.  But verifying that dependencies are satisfied in
        # that case is rather hairy.
        if False and rlibs:
            rlibs = {lib.basename for lib in rlibs}
            undeclared_deps = rlibs - direct_linked.dependencies
            if undeclared_deps:
                raise Exception("Rust library %s does not declare dependencies on %s"
                                % (direct_linked.basename, undeclared_deps))

Comment 1

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 2

[Mike Hommey [:glandium]]

It seems this bug was obsoleted by changes to how the build system does rust in the past few years.