Status
()
People
(Reporter: enndeakin, Assigned: evilpie)
Tracking
(Blocks 1 bug)
Firefox Tracking Flags
(firefox56 wontfix, firefox57 wontfix, firefox58 wontfix, firefox59 ?, firefox64 fixed)
Details
Attachments
(1 attachment, 1 obsolete attachment)
|
20.24 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Various callers of nsITransferable::SetData will wrap nsISupports in a nsISupportsInterfacePointer, but this shouldn't be needed. Remove these.
|
Reporter | |
Comment 1•3 years ago
|
||
|
|
Reporter | |
Updated•2 years ago
|
status-firefox56:
--- → wontfix
status-firefox57:
--- → wontfix
status-firefox58:
--- → fix-optional
Priority: -- → P3
|
||
Comment 2•Last year
|
||
https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals
status-firefox59:
--- → ?
|
Assignee | |
Updated•8 months ago
|
|
|
Assignee | |
Comment 4•8 months ago
|
||
I rebased the patch. I suspect we might actually be able to completely remove nsISupportsInterfacePointer.
|
|
Assignee | |
Updated•8 months ago
|
Attachment #9015127 -
Attachment description: Rebased → Remove nsISupportsInterfacePointer usage from nsITransferables
|
|
Assignee | |
Updated•8 months ago
|
Attachment #8812180 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•8 months ago
|
||
Comment on attachment 9015127 [details] [diff] [review] Remove nsISupportsInterfacePointer usage from nsITransferables Review of attachment 9015127 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/extensions/parent/ext-clipboard.js @@ +53,5 @@ > // a nsIInputStream instance fails. > // For example HTMLEditor::InsertObject (HTMLEditorDataTransfer.cpp) > // and DataTransferItem::FillInExternalData (DataTransferItem.cpp). > // > // As a work-around, we force nsClipboard::GetNativeClipboardData to We really need to remove this work-around if we want to remove the length parameter.
|
|
Assignee | |
Comment 6•8 months ago
|
||
Comment on attachment 9015127 [details] [diff] [review] Remove nsISupportsInterfacePointer usage from nsITransferables Patch by Neil (will fix commit author) Various callers of nsITransferable::SetData will wrap nsISupports in a nsISupportsInterfacePointer, that is not really necessary, we can just use the pointer directly. Most code actually already does that.
Attachment #9015127 -
Flags: review?(bugs)
|
||
Comment 7•8 months ago
|
||
Comment on attachment 9015127 [details] [diff] [review] Remove nsISupportsInterfacePointer usage from nsITransferables I guess nsISupportsInterfacePointer was used originally to have some more consistency, but in practice it just makes code harder to follow and error prone.
Attachment #9015127 -
Flags: review?(bugs) → review+
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/15fe5851f113 Remove wrapping of nsISupports as nsISupportsInterfacePointer in transferables. r=smaug
|
||
Comment 9•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/15fe5851f113
Status: NEW → RESOLVED
Closed: 8 months ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Comment 10•8 months ago
|
||
Thanks, all! I'm pleased to see this simplified.
You need to log in
before you can comment on or make changes to this bug.
Description
•