1310193 - Remove wrapping of nsISupports in transferables

Status: RESOLVED FIXED

(Core :: DOM: Drag & Drop, defect, P3)

Description

[Neil Deakin]

Various callers of nsITransferable::SetData will wrap nsISupports in a nsISupportsInterfacePointer, but this shouldn't be needed. Remove these.

Comment 1

[Neil Deakin]

Attachment: Patch that seems to work

Comment 2

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 3

[Tom Schuster [:evilpie]]

This seems like a good idea.

Comment 4

[Tom Schuster [:evilpie]]

Attachment: Remove nsISupportsInterfacePointer usage from nsITransferables

I rebased the patch. I suspect we might actually be able to completely remove nsISupportsInterfacePointer.

Comment 5

[Tom Schuster [:evilpie]]

Comment on attachment 9015127 [details] [diff] [review]
Remove nsISupportsInterfacePointer usage from nsITransferables

Review of attachment 9015127 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/extensions/parent/ext-clipboard.js
@@ +53,5 @@
>            // a nsIInputStream instance fails.
>            // For example HTMLEditor::InsertObject (HTMLEditorDataTransfer.cpp)
>            // and DataTransferItem::FillInExternalData (DataTransferItem.cpp).
>            //
>            // As a work-around, we force nsClipboard::GetNativeClipboardData to

We really need to remove this work-around if we want to remove the length parameter.

Comment 6

[Tom Schuster [:evilpie]]

Comment on attachment 9015127 [details] [diff] [review]
Remove nsISupportsInterfacePointer usage from nsITransferables

Patch by Neil (will fix commit author)
Various callers of nsITransferable::SetData will wrap nsISupports in a nsISupportsInterfacePointer, that is not really necessary, we can just use the pointer directly. Most code actually already does that.

Comment 7

[Olli Pettay [:smaug]]

Comment on attachment 9015127 [details] [diff] [review]
Remove nsISupportsInterfacePointer usage from nsITransferables

I guess nsISupportsInterfacePointer was used originally to have some more consistency, but in practice it just makes code harder to follow and error prone.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15fe5851f113
Remove wrapping of nsISupports as nsISupportsInterfacePointer in transferables. r=smaug

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/15fe5851f113

Comment 10

[Karl Tomlinson (back Feb 2 :karlt)]

Thanks, all!  I'm pleased to see this simplified.