Remove usage of Iterator from computed.js

RESOLVED FIXED in Firefox 52

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

Trunk
Firefox 52
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [devtools-html])

Attachments

(1 attachment)

Blocking bug for loading the inspector in a content tab (Bug 1291049).

computed/computed.js relies on Iterator, which is a Firefox-only API that is made accessible to computed.js via the _Iterator global. 

_Iterator is not available in content. We should either rely on Iterator directly or use a cross browser shim (better).
Flags: qe-verify?
Whiteboard: [devtools-html]
Assignee

Updated

3 years ago
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
Iteration: --- → 52.2 - Oct 17
Comment hidden (mozreview-request)

Comment 4

3 years ago
mozreview-review
Comment on attachment 8801698 [details]
Bug 1310211 - remove usage of deprecated Iterator in computed.js;

https://reviewboard.mozilla.org/r/86378/#review85150

Thanks for doing this.

I think this is reasonable.  Looking at the code, I think it would be way simpler using Task.async; but this approach is clearly fine.
Attachment #8801698 - Flags: review?(ttromey) → review+
Assignee

Comment 5

3 years ago
Try looks green. Had my doubts about dt4 on linux32 debug, but it doesn't seem worst than usual. Plus the failing test will get a longer timeout as of Bug 1309212. (auto) landing
Assignee

Comment 6

3 years ago
(In reply to Tom Tromey :tromey from comment #4)
> Comment on attachment 8801698 [details]
> Bug 1310211 - remove usage of deprecated Iterator in computed.js;
> 
> https://reviewboard.mozilla.org/r/86378/#review85150
> 
> Thanks for doing this.
> 
> I think this is reasonable.  Looking at the code, I think it would be way
> simpler using Task.async; but this approach is clearly fine.

Thanks for the review! I agree about Task.async, here I wanted to stay as close as possible to the existing implementation to avoid unrelated issues.

Comment 7

3 years ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4379d8d91f2
remove usage of deprecated Iterator in computed.js;r=tromey

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a4379d8d91f2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Flags: qe-verify? → qe-verify-

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.