Closed
Bug 1310239
Opened 8 years ago
Closed 8 years ago
wasm: Tighten global imports
Categories
(Core :: JavaScript Engine: JIT, defect, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(3 files, 1 obsolete file)
|
3.31 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
|
6.39 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
|
15.79 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
Counterpart of https://github.com/WebAssembly/design/pull/816.
Attachment #8801142 -
Flags: review?(luke)
|
Assignee | |
Comment 1•8 years ago
|
||
Also saw that Import::func hasn't been a right name for some time.
Attachment #8801144 -
Flags: review?(luke)
|
||
Updated•8 years ago
|
Attachment #8801142 -
Flags: review?(luke) → review+
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8801144 [details] [diff] [review] 2.renaming.patch Review of attachment 8801144 [details] [diff] [review]: ----------------------------------------------------------------- Thanks on both!
Attachment #8801144 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
To be able to re-enable the faulty tests, we actually need to move the check a bit further down (otherwise in testing mode, which is used in the JS wast interpreter, this check is not done at all!).
Attachment #8801142 -
Attachment is obsolete: true
Attachment #8801158 -
Flags: review?(luke)
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8801158 [details] [diff] [review] 1.notanumber.patch Review of attachment 8801158 [details] [diff] [review]: ----------------------------------------------------------------- hah, d'oh!
Attachment #8801158 -
Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc3160ce5d5 Only allow numbers as valid global imports; r=luke https://hg.mozilla.org/integration/mozilla-inbound/rev/0a4a547ec3e8 Rename Import::func to Import::field; r=luke
|
|
||
Comment 6•8 years ago
|
||
This patch will help devs identify *which* field is causing them the problem.
Attachment #8801328 -
Flags: review?(bbouvier)
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8801328 [details] [diff] [review] failed-field-name Review of attachment 8801328 [details] [diff] [review]: ----------------------------------------------------------------- Useful for debugging, thanks!
Attachment #8801328 -
Flags: review?(bbouvier) → review+
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9bc3160ce5d5 https://hg.mozilla.org/mozilla-central/rev/0a4a547ec3e8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Pushed by lwagner@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/270a67d47803 Baldr: include field name in error message (r=bbouvier)
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/270a67d47803
You need to log in
before you can comment on or make changes to this bug.
Description
•