Create a shim for Services.getMostRecentWindow().openUILinkInWindow()

RESOLVED FIXED in Firefox 52

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: jdescottes, Assigned: tromey)

Tracking

Trunk
Firefox 52
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [devtools-html])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
The MDN Docs widget loaded by the inspector is using Services.getMostRecentWindow().openUILinkInWindow() in order to open the MDN link in a new window.

We should provide a content friendly alternative to this.

We can either extend the Services shim or create a new util/helper that would fallback on window.open when loaded in content.
Flags: qe-verify?
Whiteboard: [devtools-html]
(Assignee)

Updated

3 years ago
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Iteration: --- → 52.3 - Nov 7
Priority: P2 → P1
Comment hidden (mozreview-request)
(Reporter)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8806876 [details]
Bug 1310279 - add "wm" to Services shim;

https://reviewboard.mozilla.org/r/87332/#review90784

This looks good to me, thanks for working on it Tom!
Attachment #8806876 - Flags: review?(jdescottes) → review+
(Assignee)

Comment 3

3 years ago
Fixing eslint.
Comment hidden (mozreview-request)

Comment 5

3 years ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0440791609bd
add "wm" to Services shim; r=jdescottes

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0440791609bd
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Flags: qe-verify? → qe-verify-

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.