1310279 - Create a shim for Services.getMostRecentWindow().openUILinkInWindow()

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Julian Descottes [:jdescottes]]

The MDN Docs widget loaded by the inspector is using Services.getMostRecentWindow().openUILinkInWindow() in order to open the MDN link in a new window.

We should provide a content friendly alternative to this.

We can either extend the Services shim or create a new util/helper that would fallback on window.open when loaded in content.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1310279 - add "wm" to Services shim;

Review commit: https://reviewboard.mozilla.org/r/87332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87332/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8806876 [details]
Bug 1310279 - add "wm" to Services shim;

https://reviewboard.mozilla.org/r/87332/#review90784

This looks good to me, thanks for working on it Tom!

Comment 3

[Tom Tromey :tromey]

Fixing eslint.

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8806876 [details]
Bug 1310279 - add "wm" to Services shim;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87332/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0440791609bd
add "wm" to Services shim; r=jdescottes

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0440791609bd