1310300 - Use new string format for defining recently added "Sign Out" string which replaces old "Log Out" string

Status: RESOLVED FIXED

(Firefox for iOS :: Localization, defect, P1)

Description

[Stephan Leroux [:sleroux]]

Recently we landed a fix to rename "Log Out" to "Sign Out" [1]. In doing so, we've 'removed' the old string and 'added' a new one. Couple of things we should do:

1. Add the old string back to the codebase but mark it for deprecation. This is so in case we need to ship another 5.x build, the string is still available.

2. Rather than replacing the word in the string, any new strings should follow the new format for declaring strings. "Sign Out" should be declared as such and moved to Strings.swift

[1] https://github.com/mozilla-mobile/firefox-ios/commit/abcb0f88d157f536b4f7045b27ecb1685d0123db

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2183#attch-to-bugzilla

Comment 2

[Farhan Patel [:farhan]]

Comment on attachment 8803401 [details]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2183#attch-to-bugzilla

Looks good. Too bad you can't actually mark it as deprecated so that the compiler actually shows it.

Comment 3

[Stephan Leroux [:sleroux]]

https://github.com/mozilla-mobile/firefox-ios/commit/bd689d7e33726d9452080dd909bf3abf62b8373f