Use new string format for defining recently added "Sign Out" string which replaces old "Log Out" string

RESOLVED FIXED

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sleroux, Assigned: sleroux)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios6.0+)

Details

(Whiteboard: [MobileAS])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Recently we landed a fix to rename "Log Out" to "Sign Out" [1]. In doing so, we've 'removed' the old string and 'added' a new one. Couple of things we should do:

1. Add the old string back to the codebase but mark it for deprecation. This is so in case we need to ship another 5.x build, the string is still available.

2. Rather than replacing the word in the string, any new strings should follow the new format for declaring strings. "Sign Out" should be declared as such and moved to Strings.swift

[1] https://github.com/mozilla-mobile/firefox-ios/commit/abcb0f88d157f536b4f7045b27ecb1685d0123db
(Assignee)

Updated

2 years ago
Assignee: nobody → sleroux
Status: NEW → ASSIGNED

Updated

2 years ago
Priority: P2 → P1

Updated

2 years ago
Iteration: --- → 1.7
(Assignee)

Comment 1

2 years ago
Created attachment 8803401 [details]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2183#attch-to-bugzilla
Attachment #8803401 - Flags: review?(fpatel)
Comment on attachment 8803401 [details]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2183#attch-to-bugzilla

Looks good. Too bad you can't actually mark it as deprecated so that the compiler actually shows it.
Attachment #8803401 - Flags: review?(fpatel) → review+
(Assignee)

Comment 3

2 years ago
https://github.com/mozilla-mobile/firefox-ios/commit/bd689d7e33726d9452080dd909bf3abf62b8373f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
tracking-fxios: --- → 6.0+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.