1310305 - Crash in nr_stun_message_has_attribute

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Byron Campen [:bwc]]

This bug was filed from the Socorro interface and is 
report bp-b0f7240f-452d-4094-b187-2a3bc2161008.
=============================================================

Looks like a nullptr crash due to |res| here: https://hg.mozilla.org/releases/mozilla-release/annotate/2d931a5eaf8a/media/mtransport/third_party/nICEr/src/stun/stun_server_ctx.c#l347

Should be an easy fix.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1310305: skip responding when failed to parse STUN message.

Review commit: https://reviewboard.mozilla.org/r/86106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86106/

Comment 2

[Michael Froman [:mjf]]

Comment on attachment 8801318 [details]
Bug 1310305: skip responding when failed to parse STUN message.

https://reviewboard.mozilla.org/r/86106/#review85040

Looks good to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08995043f1a6
skip responding when failed to parse STUN message. r=mjf

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/08995043f1a6

Comment 5

[Nils Ohlmeier [:drno]]

Thanks Marco.

Since I only see 22 crashes since beginning of August I think we could simply let this ride the trains. The only one which concerns me a little bit is that ESR is affected.