1310331 - Support match_about_blank in tabs.executeScript

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect, P3)

Description

[Tomislav Jovanovic :zombie]

+++ This bug was initially created as a clone of Bug #1272890 +++

Filed as followup after I scoped the original down to only content scripts.

Comment 1

[Tomislav Jovanovic :zombie]

For this to work on about:blank documents loaded in top-level windows (tabs), I believe we need to check permissions against the tab's opener, so marking this blocked on bug 1238314.

We don't need openerTabId, but the decision/platform support on how to reliably determine the opener from that bug.

Comment 2

[Kris Maglione [:kmag]]

This shouldn't depend on tab opener support. `tabs.create` doesn't support inherited origins, and that won't change with opener support. Origins inherited in windows created with `window.open` might come into play, but only the actual principal of the document should matter in that case.

Comment 3

[Tomislav Jovanovic :zombie]

Attachment: bug 1310331 - implement matchAboutBlank for tabs.executeScript

Review commit: https://reviewboard.mozilla.org/r/90378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90378/

Comment 4

[Tomislav Jovanovic :zombie]

Comment on attachment 8807101 [details]
bug 1310331 - implement matchAboutBlank for tabs.executeScript

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90378/diff/1-2/

Comment 5

[Tomislav Jovanovic :zombie]

Comment on attachment 8807101 [details]
bug 1310331 - implement matchAboutBlank for tabs.executeScript

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90378/diff/2-3/

Comment 6

[Tomislav Jovanovic :zombie]

Comment on attachment 8807101 [details]
bug 1310331 - implement matchAboutBlank for tabs.executeScript

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90378/diff/3-4/

Comment 7

[Tomislav Jovanovic :zombie]

Comment on attachment 8807101 [details]
bug 1310331 - implement matchAboutBlank for tabs.executeScript

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90378/diff/4-5/

Comment 8

[Kris Maglione [:kmag]]

Comment on attachment 8807101 [details]
bug 1310331 - implement matchAboutBlank for tabs.executeScript

https://reviewboard.mozilla.org/r/90378/#review92554

Nice! Thanks

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4971c7511bbc
implement matchAboutBlank for tabs.executeScript r=kmag

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4971c7511bbc

Comment 11

[CosminB]

Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1272890#c0 and https://bugzilla.mozilla.org/show_bug.cgi?id=1272890#c36 this issue is verified as fixed on Firefox 53.0a1 (20161121030224) under Windows 7 64-bit and Ubuntu 16.04 LTS 32-bit, after the script is executed '44' is displayed in the browser console and in the web page.

Here is a video: http://screencast.com/t/1FJCDlCx

Comment 12

[Jérémie Bertrand]

I have tried it with Firefox 53.0a2 (2017-01-30) (64-bit) on Windows 10 64-bit and it works for executeScript (file or code) but not tabs.sendMessage, which is the method I use to pass some parameters to the injected script.

I have the "Could not establish connection. Receiving end does not exist." error if I execute the sendMessage on the id of the new "about:blank" tab, and "An unexpected error occurred" error if I execute it in the callback of the executeScript.

Is there any limitation on sendMessage for about:blank page? I haven't found any information about that or a matchAboutBlank parameter.

Is this a wanted limitation or another bug?

Thanks.

Comment 13

[Tomislav Jovanovic :zombie]

I'm not sure I follow, but if you can provide a simplified extension that exhibits the problem, please feel free to file a new bug.

Comment 14

[Jérémie Bertrand]

My bad, the issue is the submission on a custom form on the blank tab (the form is created through a content script injected in the blank tab).
This bug is fixed, I will submit a new for the submission issue.