1310337 - Stop using chrome urls in inspector stylesheets

Status: RESOLVED DUPLICATE of bug 1311541

(DevTools :: Inspector, defect)

Description

[Julian Descottes [:jdescottes]]

Blocking Bug 1291049.

To enable images from stylesheets when loading the inspector in html, the stylesheets used by the inspector should not rely on chrome URLs.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1310337 - remove chrome urls from inspector stylesheets;

Review commit: https://reviewboard.mozilla.org/r/86122/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86122/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8801342 [details]
Bug 1310337 - remove chrome urls from inspector stylesheets;

https://reviewboard.mozilla.org/r/86122/#review84726

Clearing until the test issue I mentioned on IRC is fixed.

Comment 3

[Julian Descottes [:jdescottes]]

While related to loading the inspector in a content tab, the impact of this bug is that images won't be displayed, but technically it doesn't prevent using the inspector.

After reviewing the remaining bugs I still have to log, I think we should put this one in the reserve. Unassigning myself at the moment.

Comment 4

[Julian Descottes [:jdescottes]]

Summary of our conversion on IRC. With the patch attached here the test at browser/base/content/test/general/browser_parsable_css.js will fail. 

We already have some images loaded via relative URLs in our stylesheets which are whitelisted in this test.
See the discussion in Bug 1302708 for hints at how to handle this (load & package the images as resources apparently).

The end goal of this bug remains to be able to have images when using the inspector in a content tab. If another solution (let the development server rewrite the stylesheet dynamically?) seems more appropriate and less impacting for the "real" devtools, we should also consider it.

Comment 5

[Julian Descottes [:jdescottes]]

This will be fully handled by Bug 1311541.