Closed Bug 1310385 Opened 3 years ago Closed 3 years ago

Remove support for UndoManager

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: ehsan, Unassigned)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

There hasn't been any traction on this feature, and we keep
paying the maintenance and code size and memory usage penalty
of having this implementation.

We can revive this from VCS history in the future if we decide
to start working on it again.  In the mean time, it's better
to remove it.
Attachment #8801414 - Flags: review?(bugs)
Comment on attachment 8801414 [details] [diff] [review]
Remove support for UndoManager

-    "DOMTransactionEvent",
-// IMPORTANT: Do not change this list without review from a DOM peer!

oh crap, we've exposed some of this stuff to the web :(
Attachment #8801414 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8801414 [details] [diff] [review]
> Remove support for UndoManager
> 
> -    "DOMTransactionEvent",
> -// IMPORTANT: Do not change this list without review from a DOM peer!
> 
> oh crap, we've exposed some of this stuff to the web :(

Sadly yes.  :(
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa17bd43674a
Remove support for UndoManager; r=smaug
https://hg.mozilla.org/mozilla-central/rev/fa17bd43674a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
MDN apparently has some mentions of the API, e.g. https://developer.mozilla.org/en-US/docs/Web/API/Element

No site-compat effect since it's disabled by default.
Keywords: dev-doc-needed
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.