change SetImageRequest and SetStyleimageRequest to return their objects

RESOLVED FIXED in Firefox 53

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: heycam, Assigned: xidorn)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Instead of taking a callback function, we should just make SetImageRequest and SetStyleImageRequest just return the new imgRequestProxy/nsStyleImageRequest and have the calling code caller do the appropriate setter calling or assignment.
(Assignee)

Updated

a year ago
Assignee: nobody → xidorn+moz
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8815603 [details]
Bug 1310404 part 1 - Convert SetImageRequest to CreateImageRequest.

https://reviewboard.mozilla.org/r/96472/#review96696

::: layout/style/nsRuleNode.cpp:112
(Diff revision 1)
>  // Creates an imgRequestProxy based on the specified value in
>  // aValue and calls aCallback with it.  If the nsPresContext
>  // is static (e.g. for printing), then a static request (i.e.
>  // showing the first frame, without animation) will be created.
>  // (The expectation is then that aCallback will set the resulting
>  // imgRequestProxy in a style struct somewhere.)

Please update the comment.
Attachment #8815603 - Flags: review?(cam) → review+
(Reporter)

Comment 5

a year ago
mozreview-review
Comment on attachment 8815604 [details]
Bug 1310404 part 2 - Convert SetStyleimageRequest to CreateStyleImageRequest.

https://reviewboard.mozilla.org/r/96474/#review96698
Attachment #8815604 - Flags: review?(cam) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 10

a year ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9166fe1b7814
part 1 - Convert SetImageRequest to CreateImageRequest. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b393d76118f3
part 2 - Convert SetStyleimageRequest to CreateStyleImageRequest. r=heycam

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9166fe1b7814
https://hg.mozilla.org/mozilla-central/rev/b393d76118f3
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.