1310404 - change SetImageRequest and SetStyleimageRequest to return their objects

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

Instead of taking a callback function, we should just make SetImageRequest and SetStyleImageRequest just return the new imgRequestProxy/nsStyleImageRequest and have the calling code caller do the appropriate setter calling or assignment.

Comment 1

[Cameron McCormack (:heycam)]

(per bug 1288302 comment 20)

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1310404 part 1 - Convert SetImageRequest to CreateImageRequest.

Review commit: https://reviewboard.mozilla.org/r/96472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96472/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1310404 part 2 - Convert SetStyleimageRequest to CreateStyleImageRequest.

Review commit: https://reviewboard.mozilla.org/r/96474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96474/

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8815603 [details]
Bug 1310404 part 1 - Convert SetImageRequest to CreateImageRequest.

https://reviewboard.mozilla.org/r/96472/#review96696

::: layout/style/nsRuleNode.cpp:112
(Diff revision 1)
>  // Creates an imgRequestProxy based on the specified value in
>  // aValue and calls aCallback with it.  If the nsPresContext
>  // is static (e.g. for printing), then a static request (i.e.
>  // showing the first frame, without animation) will be created.
>  // (The expectation is then that aCallback will set the resulting
>  // imgRequestProxy in a style struct somewhere.)

Please update the comment.

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8815604 [details]
Bug 1310404 part 2 - Convert SetStyleimageRequest to CreateStyleImageRequest.

https://reviewboard.mozilla.org/r/96474/#review96698

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8815603 [details]
Bug 1310404 part 1 - Convert SetImageRequest to CreateImageRequest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96472/diff/1-2/

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8815604 [details]
Bug 1310404 part 2 - Convert SetStyleimageRequest to CreateStyleImageRequest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96474/diff/1-2/

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8815603 [details]
Bug 1310404 part 1 - Convert SetImageRequest to CreateImageRequest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96472/diff/2-3/

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8815604 [details]
Bug 1310404 part 2 - Convert SetStyleimageRequest to CreateStyleImageRequest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96474/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9166fe1b7814
part 1 - Convert SetImageRequest to CreateImageRequest. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b393d76118f3
part 2 - Convert SetStyleimageRequest to CreateStyleImageRequest. r=heycam

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9166fe1b7814
https://hg.mozilla.org/mozilla-central/rev/b393d76118f3